Skip to content

Conversation

@d-gubert
Copy link
Member

@d-gubert d-gubert commented Aug 4, 2025

Proposed changes (including videos or screenshots)

Fix logs export being generated without taking the instance filter into account

Issue(s)

Steps to test or reproduce

Further comments

ALT-33

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 4, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2025

🦋 Changeset detected

Latest commit: dbc9fa6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages
Name Type
@rocket.chat/rest-typings Patch
@rocket.chat/meteor Patch
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/http-router Patch
@rocket.chat/models Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/network-broker Patch
@rocket.chat/livechat Patch
@rocket.chat/mock-providers Patch
@rocket.chat/cron Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/core-typings Patch
@rocket.chat/apps Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@d-gubert d-gubert added this to the 7.10.0 milestone Aug 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36611/

Built to branch gh-pages at 2025-08-07 14:23 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.67%. Comparing base (be7ceaa) to head (dbc9fa6).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36611      +/-   ##
===========================================
+ Coverage    65.65%   65.67%   +0.01%     
===========================================
  Files         3197     3197              
  Lines       106812   106803       -9     
  Branches     20332    20329       -3     
===========================================
+ Hits         70130    70139       +9     
+ Misses       34035    34020      -15     
+ Partials      2647     2644       -3     
Flag Coverage Δ
e2e 56.96% <0.00%> (+<0.01%) ⬆️
unit 71.22% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@d-gubert d-gubert marked this pull request as ready for review August 4, 2025 15:50
@d-gubert d-gubert requested review from a team as code owners August 4, 2025 15:50
@d-gubert d-gubert force-pushed the fix/logs-export-instance-filter branch from 670884e to 63c5ca4 Compare August 4, 2025 19:49
@d-gubert d-gubert force-pushed the fix/logs-export-instance-filter branch from 63c5ca4 to 5f667b5 Compare August 4, 2025 21:36
@d-gubert d-gubert requested a review from MartinSchoeler August 5, 2025 12:48
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Aug 7, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 7, 2025
@kodiakhq kodiakhq bot merged commit 2fea1a7 into develop Aug 7, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/logs-export-instance-filter branch August 7, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants