fix: create-c and create-p not being applied to Team Creation #36592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
Contributor
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #36592 +/- ##
===========================================
+ Coverage 65.70% 65.77% +0.06%
===========================================
Files 3199 3200 +1
Lines 106892 106886 -6
Branches 20343 20362 +19
===========================================
+ Hits 70232 70299 +67
+ Misses 34015 33936 -79
- Partials 2645 2651 +6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
🦋 Changeset detectedLatest commit: 8545509 The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dougfabris
requested changes
Aug 5, 2025
dougfabris
force-pushed
the
fix/private-team-permission
branch
from
ea09d03 to
5b0090c
Compare
dougfabris
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
When the "Create Private/Public Channels" permission is turned off, the team creation UI still allows selecting a private team. However, attempting to create such a team results in an API error ("error-team-creation"). This is inconsistent with the channel creation UI, which disables the public/private toggle when the corresponding permission is off.
Since the Team has a main "channel", the user needs both create-team and create-c or create-p to be able to create a team
Issue(s)
SUP-747
Steps to test or reproduce
Disable the "Create Private Channels" permission for the user role.
Attempt to create a new team with the payload:
For public team → Succeeds
For private team → Fails with "error-team-creation"