Skip to content

Conversation

@d-gubert
Copy link
Member

@d-gubert d-gubert commented Jul 30, 2025

Proposed changes (including videos or screenshots)

In the app details page, the Instances tab list has a View Logs button for each item, but the button currently redirects to the logs tab without filtering by the instanceID

Issue(s)

Steps to test or reproduce

Further comments

ALT-32

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 30, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 30, 2025

🦋 Changeset detected

Latest commit: 510b505

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch
@rocket.chat/omni-core-ee Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@d-gubert d-gubert added this to the 7.10.0 milestone Jul 30, 2025
@d-gubert d-gubert requested a review from MartinSchoeler July 30, 2025 13:02
@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36569/

Built to branch gh-pages at 2025-08-01 19:42 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.67%. Comparing base (c0c8919) to head (510b505).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #36569   +/-   ##
========================================
  Coverage    65.67%   65.67%           
========================================
  Files         3195     3196    +1     
  Lines       106699   106685   -14     
  Branches     20316    20325    +9     
========================================
- Hits         70070    70061    -9     
+ Misses       33985    33979    -6     
- Partials      2644     2645    +1     
Flag Coverage Δ
e2e 56.94% <0.00%> (-0.02%) ⬇️
unit 71.23% <20.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@d-gubert d-gubert marked this pull request as ready for review July 30, 2025 15:51
@d-gubert d-gubert requested a review from a team as a code owner July 30, 2025 15:51
@d-gubert d-gubert force-pushed the fix/view-logs-instance-button branch from 7d5c71b to 8e1666f Compare July 30, 2025 15:51
@d-gubert d-gubert marked this pull request as draft July 30, 2025 16:17
@d-gubert d-gubert marked this pull request as ready for review July 30, 2025 19:28
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Aug 1, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 1, 2025
@kodiakhq kodiakhq bot merged commit 42b1495 into develop Aug 1, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/view-logs-instance-button branch August 1, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants