Skip to content

refactor: provide env vars to federation sdk instead of loading them internally #36557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ricardogarim merged 1 commit into from
Jul 29, 2025
Merged

refactor: provide env vars to federation sdk instead of loading them internally #36557

ricardogarim merged 1 commit into from
Jul 29, 2025

Conversation

@MarcosSpessatto
Copy link
Contributor

@MarcosSpessatto MarcosSpessatto commented Jul 29, 2025

https://rocketchat.atlassian.net/browse/FDR-88

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 29, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2025

⚠️ No Changeset found

Latest commit: 9a23352

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ricardogarim ricardogarim marked this pull request as ready for review July 29, 2025 22:45
@ricardogarim ricardogarim merged commit 44732e1 into feat/federation Jul 29, 2025
28 of 30 checks passed
@ricardogarim ricardogarim deleted the refactor/provide-env-vars-to-fed-sdk branch July 29, 2025 22:45
ricardogarim pushed a commit that referenced this pull request Aug 3, 2025
@ricardogarim
refactor: provide env vars to federation sdk instead of loading them …
a90c9d6 
…internally (#36557)
debdutdeb pushed a commit that referenced this pull request Aug 18, 2025
@debdutdeb
refactor: provide env vars to federation sdk instead of loading them …
cc24ef3 
…internally (#36557)
sampaiodiego pushed a commit that referenced this pull request Aug 21, 2025
@sampaiodiego
refactor: provide env vars to federation sdk instead of loading them …
bd78ac9 
…internally (#36557)
sampaiodiego pushed a commit that referenced this pull request Sep 2, 2025
@sampaiodiego
refactor: provide env vars to federation sdk instead of loading them …
6b72ff3 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 16, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
49413c3 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
b0ab7ed 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
4a67293 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
3b7bdfd 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
e9aa957 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
facf997 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
21722fd 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
e49f20e 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
acc01d3 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
6a6f4d8 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
28ebc3b 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
297a95b 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
53a0c0c 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
99fb2f7 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
0ab28d6 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
a6ecac4 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
a968858 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
2f681e6 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
6ef24e3 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
8c36d1d 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
8b1bfea 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
d5f405b 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
4de390f 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
289021a 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 17, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
7730466 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 18, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
034afe8 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 18, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
5ea1524 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 18, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
50ea290 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 18, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
dde727f 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 18, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
7174aa2 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 18, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
a9b07e3 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 19, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
39b01d6 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 19, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
3bf7398 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 23, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
19a2a00 
…internally (#36557)
ggazzo pushed a commit that referenced this pull request Sep 25, 2025
@ggazzo
refactor: provide env vars to federation sdk instead of loading them …
63d092d 
…internally (#36557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricardogarim ricardogarim ricardogarim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MarcosSpessatto @ricardogarim