-
Notifications
You must be signed in to change notification settings - Fork 13k
chore: Change the error message when transfer fails because of no assignement to avoid confusion #36528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Change the error message when transfer fails because of no assignement to avoid confusion #36528
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #36528 +/- ##
========================================
Coverage 65.80% 65.80%
========================================
Files 3188 3188
Lines 106922 106922
Branches 20389 20391 +2
========================================
+ Hits 70357 70364 +7
+ Misses 33892 33886 -6
+ Partials 2673 2672 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
c5be7cf to
2705d99
Compare
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/CTZ-287
Steps to test or reproduce
Further comments
This is to avoid confusion. A transfer could fail even when there are online agents but they're over their limits for taking chats, so saying "no online agents" is misleading.
Now, the message is changed to "not available for service" to indicate they're just not available.