Skip to content

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented Jul 24, 2025

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CTZ-287

Steps to test or reproduce

Further comments

This is to avoid confusion. A transfer could fail even when there are online agents but they're over their limits for taking chats, so saying "no online agents" is misleading.

Now, the message is changed to "not available for service" to indicate they're just not available.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 24, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.10.0, but it targets 7.9.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2025

⚠️ No Changeset found

Latest commit: 2705d99

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36528/

Built to branch gh-pages at 2025-07-28 14:12 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.80%. Comparing base (4ad328f) to head (2705d99).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #36528   +/-   ##
========================================
  Coverage    65.80%   65.80%           
========================================
  Files         3188     3188           
  Lines       106922   106922           
  Branches     20389    20391    +2     
========================================
+ Hits         70357    70364    +7     
+ Misses       33892    33886    -6     
+ Partials      2673     2672    -1     
Flag Coverage Δ
e2e 58.11% <ø> (-0.01%) ⬇️
unit 70.94% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from fix/to-queue-on-waitin-queue to develop July 25, 2025 14:37
@KevLehman KevLehman force-pushed the chore/change-error-message-when-transfer-fails branch from c5be7cf to 2705d99 Compare July 28, 2025 14:04
@KevLehman KevLehman marked this pull request as ready for review July 28, 2025 15:11
@KevLehman KevLehman requested review from a team as code owners July 28, 2025 15:11
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Jul 28, 2025
@KevLehman KevLehman added this to the 7.10.0 milestone Jul 28, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 28, 2025
@kodiakhq kodiakhq bot merged commit e5a6899 into develop Jul 28, 2025
52 checks passed
@kodiakhq kodiakhq bot deleted the chore/change-error-message-when-transfer-fails branch July 28, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants