-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: empty thread preview #36527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: empty thread preview #36527
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: ef60e6c The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #36527 +/- ##
===========================================
- Coverage 65.89% 65.87% -0.03%
===========================================
Files 3191 3193 +2
Lines 106814 106868 +54
Branches 20310 20380 +70
===========================================
+ Hits 70389 70402 +13
- Misses 33749 33809 +60
+ Partials 2676 2657 -19
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
17c9c50 to
5322a8f
Compare
053a3a4 to
8df4002
Compare
dougfabris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
dougfabris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Proposed changes (including videos or screenshots)
Fixes a condition that caused quoted messages to not be rendering on a thread message preview
Issue(s)
CORE-539
Steps to test or reproduce
Open a channel
Send 2 different messages
Hover the first message sent → Copy link
On the second message, start a thread with a text and the link from the previous message
Further comments