Skip to content

Conversation

@MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented Jul 24, 2025

Proposed changes (including videos or screenshots)

Fixes a condition that caused quoted messages to not be rendering on a thread message preview

Issue(s)

CORE-539

Steps to test or reproduce

  • Open a channel

  • Send 2 different messages

  • Hover the first message sent → Copy link

  • On the second message, start a thread with a text and the link from the previous message

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 24, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2025

🦋 Changeset detected

Latest commit: ef60e6c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch
@rocket.chat/omni-core-ee Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36527/

Built to branch gh-pages at 2025-07-31 18:35 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.87%. Comparing base (8942187) to head (ef60e6c).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36527      +/-   ##
===========================================
- Coverage    65.89%   65.87%   -0.03%     
===========================================
  Files         3191     3193       +2     
  Lines       106814   106868      +54     
  Branches     20310    20380      +70     
===========================================
+ Hits         70389    70402      +13     
- Misses       33749    33809      +60     
+ Partials      2676     2657      -19     
Flag Coverage Δ
e2e 57.91% <100.00%> (+0.01%) ⬆️
unit 71.17% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MartinSchoeler MartinSchoeler force-pushed the fix/empty-thread-preview branch from 17c9c50 to 5322a8f Compare July 24, 2025 19:49
@MartinSchoeler MartinSchoeler marked this pull request as ready for review July 25, 2025 13:06
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner July 25, 2025 13:06
@MartinSchoeler MartinSchoeler force-pushed the fix/empty-thread-preview branch from 053a3a4 to 8df4002 Compare July 25, 2025 13:07
@MartinSchoeler MartinSchoeler added this to the 7.10.0 milestone Jul 25, 2025
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But, I'm missing changesets

@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Jul 31, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 31, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jul 31, 2025
@dougfabris dougfabris added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Jul 31, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 31, 2025
@kodiakhq kodiakhq bot merged commit e4a3b7c into develop Jul 31, 2025
87 of 89 checks passed
@kodiakhq kodiakhq bot deleted the fix/empty-thread-preview branch July 31, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants