chore(deps): remove pdfjs-dist #36509
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repository has a broken symbolic link under
apps/meteor/public/pdf.worker.min.jsIt points to
node_modules/pdfjs-dist/build/pdf.worker.min.jswhich doesn't exist, causing some tools to malfunction such as turborepo (turbo boundaries).Upon inspecting the git history it seems this dependency hasn't been used for a very long time.
The symbolic link was added here:
The file was removed from pdfjs here:
The symbolic link was broken here (7.4.0) when upgrading the dependency:
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-1256
Steps to test or reproduce
Further comments