Skip to content

Conversation

@cardoso
Copy link
Member

@cardoso cardoso commented Jul 23, 2025

The repository has a broken symbolic link under apps/meteor/public/pdf.worker.min.js

It points to node_modules/pdfjs-dist/build/pdf.worker.min.js which doesn't exist, causing some tools to malfunction such as turborepo (turbo boundaries).

Upon inspecting the git history it seems this dependency hasn't been used for a very long time.

The symbolic link was added here:

The file was removed from pdfjs here:

The symbolic link was broken here (7.4.0) when upgrading the dependency:

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-1256

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 23, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.10.0, but it targets 7.9.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 23, 2025

⚠️ No Changeset found

Latest commit: 29f6163

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36509/

Built to branch gh-pages at 2025-07-23 18:33 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.13%. Comparing base (71bfd07) to head (29f6163).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36509      +/-   ##
===========================================
- Coverage    65.67%   65.13%   -0.55%     
===========================================
  Files         3174     3094      -80     
  Lines       105850   104659    -1191     
  Branches     20101    19853     -248     
===========================================
- Hits         69521    68167    -1354     
- Misses       33656    33909     +253     
+ Partials      2673     2583      -90     
Flag Coverage Δ
e2e 56.20% <ø> (-1.90%) ⬇️
unit 70.81% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cardoso cardoso marked this pull request as ready for review July 23, 2025 19:39
@cardoso cardoso added this to the 7.10.0 milestone Jul 23, 2025
@tassoevan tassoevan merged commit 14f5b99 into develop Jul 23, 2025
76 of 78 checks passed
@tassoevan tassoevan deleted the chore/remove-pdfjs-dist branch July 23, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants