Skip to content

Conversation

@d-gubert
Copy link
Member

@d-gubert d-gubert commented Jul 23, 2025

Proposed changes (including videos or screenshots)

If an app subprocess failed to construct the app, the installation would be stopped, but the subprocess itself would linger in the manager, preventing further attempts to install the same app

Issue(s)

Steps to test or reproduce

Further comments

CORE-1251

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 23, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.10.0, but it targets 7.9.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 23, 2025

🦋 Changeset detected

Latest commit: edb4435

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/apps-engine Patch
@rocket.chat/meteor Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/core-typings Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36504/

Built to branch gh-pages at 2025-07-25 15:13 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@d-gubert d-gubert force-pushed the fix/app-installation-construction branch 2 times, most recently from da8913f to fc9d21e Compare July 23, 2025 13:09
@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.71%. Comparing base (ababb7a) to head (edb4435).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36504      +/-   ##
===========================================
- Coverage    65.72%   65.71%   -0.01%     
===========================================
  Files         3174     3174              
  Lines       106449   106449              
  Branches     20319    20295      -24     
===========================================
- Hits         69967    69958       -9     
- Misses       33809    33816       +7     
- Partials      2673     2675       +2     
Flag Coverage Δ
e2e 58.13% <ø> (+0.01%) ⬆️
unit 70.82% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@d-gubert d-gubert force-pushed the fix/app-installation-construction branch 2 times, most recently from 3979688 to b3dd5d3 Compare July 23, 2025 14:57
@d-gubert d-gubert marked this pull request as ready for review July 23, 2025 17:00
@d-gubert d-gubert requested a review from a team as a code owner July 23, 2025 17:00
@d-gubert d-gubert added this to the 7.10.0 milestone Jul 23, 2025
@d-gubert d-gubert force-pushed the fix/app-installation-construction branch from 4fe00a2 to 713f03f Compare July 25, 2025 12:51
@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Jul 25, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 25, 2025
@kodiakhq kodiakhq bot merged commit 02a555a into develop Jul 25, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/app-installation-construction branch July 25, 2025 15:58
@sampaiodiego sampaiodiego modified the milestones: 7.10.0, 7.9.0 Jul 25, 2025
@sampaiodiego
Copy link
Member

/patch

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 25, 2025

Pull request #36537 added to Project: "Patch 7.8.3"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants