Skip to content

Conversation

@MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented Jul 22, 2025

https://rocketchat.atlassian.net/browse/ARCH-1724

Proposed changes (including videos or screenshots)

Adds the ability to use iso strings on timestamps in the message parser package

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 22, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.10.0, but it targets 7.9.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2025

⚠️ No Changeset found

Latest commit: 67eb399

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36498/

Built to branch gh-pages at 2025-07-24 14:06 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

Attention: Patch coverage is 44.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 65.73%. Comparing base (960a914) to head (67eb399).
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36498      +/-   ##
===========================================
+ Coverage    65.38%   65.73%   +0.34%     
===========================================
  Files         3191     3174      -17     
  Lines       106414   106380      -34     
  Branches     20257    20307      +50     
===========================================
+ Hits         69581    69929     +348     
+ Misses       34130    33777     -353     
+ Partials      2703     2674      -29     
Flag Coverage Δ
e2e 58.10% <ø> (+0.34%) ⬆️
unit 70.85% <44.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MartinSchoeler MartinSchoeler force-pushed the feat/timestamp-isoTime branch from 573300f to f6fe338 Compare July 22, 2025 21:30
@MartinSchoeler MartinSchoeler changed the title chore: Make timestamp accept ISO time feat: Make timestamp accept ISO time Jul 22, 2025
@MartinSchoeler MartinSchoeler changed the title feat: Make timestamp accept ISO time feat(message-parser): Make timestamp accept ISO time Jul 22, 2025
@MartinSchoeler MartinSchoeler marked this pull request as ready for review July 24, 2025 14:04
@MartinSchoeler MartinSchoeler added this to the 7.10.0 milestone Jul 24, 2025
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jul 24, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 24, 2025
@ggazzo ggazzo merged commit 85f227a into develop Jul 24, 2025
74 of 76 checks passed
@ggazzo ggazzo deleted the feat/timestamp-isoTime branch July 24, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants