Skip to content

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented Jul 22, 2025

Proposed changes (including videos or screenshots)

Fixes a behavior when transferring a room to another department that was not considering the waiting queue setting and attempted to route the chat to an agent instead of leaving it on the department's queue

Issue(s)

https://rocketchat.atlassian.net/browse/CTZ-280

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2025

🦋 Changeset detected

Latest commit: 7761b5a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 22, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36494/

Built to branch gh-pages at 2025-07-25 13:55 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.72%. Comparing base (cc95107) to head (7761b5a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #36494   +/-   ##
========================================
  Coverage    65.72%   65.72%           
========================================
  Files         3174     3174           
  Lines       106449   106449           
  Branches     20315    20320    +5     
========================================
+ Hits         69963    69965    +2     
+ Misses       33815    33813    -2     
  Partials      2671     2671           
Flag Coverage Δ
e2e 58.11% <ø> (-0.01%) ⬇️
unit 70.85% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KevLehman KevLehman added this to the 7.9.0 milestone Jul 22, 2025
@KevLehman KevLehman marked this pull request as ready for review July 22, 2025 17:12
@KevLehman KevLehman requested review from a team as code owners July 22, 2025 17:12
@scuciatto
Copy link
Member

Can we have a proper description for this PR, please?

@KevLehman KevLehman force-pushed the fix/to-queue-on-waitin-queue branch from a64646f to 56b4069 Compare July 22, 2025 19:38
@ggazzo
Copy link
Member

ggazzo commented Jul 22, 2025

Any chance to have tests running in a separated pr? Expecting to fail of course

@KevLehman
Copy link
Member Author

Any chance to have tests running in a separated pr? Expecting to fail of course

U mean so the patch is easier? Or do u have other reason in mind? : 👀

sampaiodiego
sampaiodiego previously approved these changes Jul 23, 2025
@KevLehman KevLehman requested a review from sampaiodiego July 23, 2025 20:27
sampaiodiego
sampaiodiego previously approved these changes Jul 23, 2025
@renatobecker renatobecker added the stat: QA assured Means it has been tested and approved by a company insider label Jul 24, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 24, 2025
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tests are not covering the changes, I ran them against develop and they all passed as well..

@kodiakhq kodiakhq bot merged commit ababb7a into develop Jul 25, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/to-queue-on-waitin-queue branch July 25, 2025 14:37
@sampaiodiego
Copy link
Member

/patch

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 25, 2025

Pull request #36534 added to Project: "Patch 7.8.3"

@sampaiodiego
Copy link
Member

/backport 7.7.7

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 25, 2025

Pull request #36536 added to Project: "Patch 7.7.7"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants