-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: Queue chat when transferring and waiting queue is active #36494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 7761b5a The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36494 +/- ##
========================================
Coverage 65.72% 65.72%
========================================
Files 3174 3174
Lines 106449 106449
Branches 20315 20320 +5
========================================
+ Hits 69963 69965 +2
+ Misses 33815 33813 -2
Partials 2671 2671
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Can we have a proper description for this PR, please? |
a64646f to
56b4069
Compare
|
Any chance to have tests running in a separated pr? Expecting to fail of course |
U mean so the patch is easier? Or do u have other reason in mind? : 👀 |
sampaiodiego
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the tests are not covering the changes, I ran them against develop and they all passed as well..
|
/patch |
|
Pull request #36534 added to Project: "Patch 7.8.3" |
|
/backport 7.7.7 |
|
Pull request #36536 added to Project: "Patch 7.7.7" |
Proposed changes (including videos or screenshots)
Fixes a behavior when transferring a room to another department that was not considering the
waiting queuesetting and attempted to route the chat to an agent instead of leaving it on the department's queueIssue(s)
https://rocketchat.atlassian.net/browse/CTZ-280
Steps to test or reproduce
Further comments