-
Notifications
You must be signed in to change notification settings - Fork 13k
regression: add missing check for 'all' in app logs export #36485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppLogs/Filters/ExportLogsModal.tsx
Outdated
Show resolved
Hide resolved
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.9.0 #36485 +/- ##
=================================================
+ Coverage 65.72% 65.73% +0.01%
=================================================
Files 3174 3174
Lines 105831 105838 +7
Branches 20180 20108 -72
=================================================
+ Hits 69553 69570 +17
+ Misses 33600 33595 -5
+ Partials 2678 2673 -5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
58a56fc to
6be2c62
Compare
6be2c62 to
94338d5
Compare
d-gubert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here goes my emotional support approval since I'm not a code owner 👍
Proposed changes (including videos or screenshots)
The checks for the 'All' option was missing on the Logs export Modal, causing the export to fail. This PR fixes that and adds a test for the specific issue
Issue(s)
ALT-26
Steps to test or reproduce
Further comments