Skip to content

Conversation

@MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented Jul 21, 2025

Proposed changes (including videos or screenshots)

The checks for the 'All' option was missing on the Logs export Modal, causing the export to fail. This PR fixes that and adds a test for the specific issue

Issue(s)

ALT-26

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 21, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2025

⚠️ No Changeset found

Latest commit: 94338d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MartinSchoeler MartinSchoeler added this to the 7.9.0 milestone Jul 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36485/

Built to branch gh-pages at 2025-07-21 20:27 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.73%. Comparing base (dcb9207) to head (94338d5).
Report is 1 commits behind head on release-7.9.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.9.0   #36485      +/-   ##
=================================================
+ Coverage          65.72%   65.73%   +0.01%     
=================================================
  Files               3174     3174              
  Lines             105831   105838       +7     
  Branches           20180    20108      -72     
=================================================
+ Hits               69553    69570      +17     
+ Misses             33600    33595       -5     
+ Partials            2678     2673       -5     
Flag Coverage Δ
e2e 58.07% <16.66%> (-0.07%) ⬇️
unit 70.90% <72.72%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review July 21, 2025 20:09
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner July 21, 2025 20:09
@MartinSchoeler MartinSchoeler requested review from a team as code owners July 21, 2025 20:12
@MartinSchoeler MartinSchoeler changed the base branch from develop to release-7.9.0 July 21, 2025 20:13
@MartinSchoeler MartinSchoeler removed request for a team July 21, 2025 20:45
Copy link
Member

@d-gubert d-gubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here goes my emotional support approval since I'm not a code owner 👍

@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Jul 22, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 22, 2025
@kodiakhq kodiakhq bot merged commit d6afa6c into release-7.9.0 Jul 22, 2025
51 checks passed
@kodiakhq kodiakhq bot deleted the regression/export branch July 22, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants