Skip to content

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jul 17, 2025

Proposed changes (including videos or screenshots)

Issue(s)

ARCH-1720

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 17, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2025

⚠️ No Changeset found

Latest commit: 398cc86

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36468/

Built to branch gh-pages at 2025-07-18 06:06 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

Attention: Patch coverage is 64.32749% with 61 lines in your changes missing coverage. Please review.

Project coverage is 65.69%. Comparing base (415d7c3) to head (398cc86).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #36468   +/-   ##
========================================
  Coverage    65.69%   65.69%           
========================================
  Files         3171     3170    -1     
  Lines       105625   105666   +41     
  Branches     20057    20050    -7     
========================================
+ Hits         69386    69420   +34     
- Misses       33562    33573   +11     
+ Partials      2677     2673    -4     
Flag Coverage Δ
e2e 58.17% <54.23%> (+<0.01%) ⬆️
unit 70.83% <64.36%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tassoevan tassoevan force-pushed the chore/use-endpoint-data branch from dbf7d6e to c99e42c Compare July 17, 2025 22:18
@tassoevan tassoevan force-pushed the chore/use-endpoint-data branch from 2593f81 to e081f1c Compare July 18, 2025 03:15
@tassoevan tassoevan changed the title chore: useEndpointData chore: Remove useEndpointData Jul 18, 2025
@tassoevan tassoevan marked this pull request as ready for review July 18, 2025 15:22
@tassoevan tassoevan requested review from a team as code owners July 18, 2025 15:22
@tassoevan tassoevan added this to the 7.9.0 milestone Jul 18, 2025
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jul 18, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 18, 2025
@ggazzo ggazzo merged commit 34c5f88 into develop Jul 18, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants