Skip to content

Conversation

@cardoso
Copy link
Member

@cardoso cardoso commented Jul 16, 2025

Proposed changes (including videos or screenshots)

This tool has been unmaintained for 3 years. The templates we use get outdated constantly and have more dependencies than is needed. Creating a new package isn’t something we’re doing often enough. When we do create a package with one of our hygen templates, it’s far from optimal: outdated deps, configs (jest, eslint), scripts, etc.

Also, the tool is used through npx which has risks associated to

typo-squatting:

supply chain:

A better solution to this is turbo gen which is already built into a tool we use and addresses most if not all the issues outlined here.

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-1245

Steps to test or reproduce

Further comments

@cardoso cardoso added this to the 7.9.0 milestone Jul 16, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 16, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 16, 2025

⚠️ No Changeset found

Latest commit: a7d84c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.56%. Comparing base (6f20510) to head (a7d84c4).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36446      +/-   ##
===========================================
+ Coverage    63.46%   65.56%   +2.10%     
===========================================
  Files         2728     3172     +444     
  Lines        98657   105477    +6820     
  Branches     18468    20044    +1576     
===========================================
+ Hits         62611    69160    +6549     
+ Misses       33865    33637     -228     
- Partials      2181     2680     +499     
Flag Coverage Δ
e2e 58.11% <ø> (+8.34%) ⬆️
unit 70.69% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36446/

Built to branch gh-pages at 2025-07-17 14:51 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@cardoso cardoso marked this pull request as ready for review July 16, 2025 15:56
@cardoso cardoso requested a review from a team as a code owner July 16, 2025 15:56
@MarcosSpessatto MarcosSpessatto added the stat: QA assured Means it has been tested and approved by a company insider label Jul 17, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 17, 2025
@kodiakhq kodiakhq bot merged commit 302ef05 into develop Jul 17, 2025
70 of 72 checks passed
@kodiakhq kodiakhq bot deleted the chore/remove-hygen branch July 17, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants