-
Notifications
You must be signed in to change notification settings - Fork 13.1k
chore: remove hygen #36446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove hygen #36446
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36446 +/- ##
===========================================
+ Coverage 63.46% 65.56% +2.10%
===========================================
Files 2728 3172 +444
Lines 98657 105477 +6820
Branches 18468 20044 +1576
===========================================
+ Hits 62611 69160 +6549
+ Misses 33865 33637 -228
- Partials 2181 2680 +499
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Proposed changes (including videos or screenshots)
This tool has been unmaintained for 3 years. The templates we use get outdated constantly and have more dependencies than is needed. Creating a new package isn’t something we’re doing often enough. When we do create a package with one of our hygen templates, it’s far from optimal: outdated deps, configs (jest, eslint), scripts, etc.
Also, the tool is used through
npxwhich has risks associated totypo-squatting:
supply chain:
A better solution to this is turbo gen which is already built into a tool we use and addresses most if not all the issues outlined here.
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-1245
Steps to test or reproduce
Further comments