Skip to content

Conversation

@tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Jul 11, 2025

Proposed changes (including videos or screenshots)

This PR fixes performance problems related to the usage of forward messages by:

  • Refactoring the component UserAndRoomAutoCompleteMultiple
  • Limiting the server search quantity of items
  • Limiting the client disposable of items filtered and mapped

Issue(s)

Steps to test or reproduce

Further comments

SUP-811

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 11, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2025

🦋 Changeset detected

Latest commit: eac27ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36404/

Built to branch gh-pages at 2025-07-16 11:32 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.51%. Comparing base (54a58f5) to head (eac27ca).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36404      +/-   ##
===========================================
+ Coverage    65.48%   65.51%   +0.02%     
===========================================
  Files         3168     3168              
  Lines       104987   105069      +82     
  Branches     19997    20004       +7     
===========================================
+ Hits         68749    68832      +83     
+ Misses       33563    33561       -2     
- Partials      2675     2676       +1     
Flag Coverage Δ
e2e 58.26% <53.84%> (+0.04%) ⬆️
unit 70.59% <90.90%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tiagoevanp tiagoevanp marked this pull request as ready for review July 15, 2025 17:39
@tiagoevanp tiagoevanp requested a review from a team as a code owner July 15, 2025 17:39
@tiagoevanp tiagoevanp added this to the 7.9.0 milestone Jul 15, 2025
gabriellsh
gabriellsh previously approved these changes Jul 15, 2025
@tiagoevanp tiagoevanp added the stat: QA assured Means it has been tested and approved by a company insider label Jul 15, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 15, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jul 15, 2025
@tiagoevanp tiagoevanp added the stat: ready to merge PR tested and approved waiting for merge label Jul 16, 2025
@kodiakhq kodiakhq bot merged commit d7edd91 into develop Jul 16, 2025
88 of 90 checks passed
@kodiakhq kodiakhq bot deleted the fix/forward_select_performance branch July 16, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants