Skip to content

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Jul 10, 2025

Proposed changes (including videos or screenshots)

This pull request solves a few issues related to the device permission & device change menu. Notable fixes:

  • Device list with unnamed devices or empty
  • No device showing as selected
  • Wrong device showing as selected
  • Changing device before making/accepting a call did not actually change the device

This PR also introduces new modals to increase information context when requesting permissions:

image image image image

The new modals also prevent the call being automatically rejected when microphone permission was blocked, by forcing the user to either reject the call or grant the permission.

Issue(s)

VAI-62

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 10, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2025

🦋 Changeset detected

Latest commit: 4580374

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/i18n Minor
@rocket.chat/mock-providers Minor
@rocket.chat/ui-client Major
@rocket.chat/ui-contexts Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/uikit-playground Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/queue-worker Patch
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/http-router Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence-service Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch
@rocket.chat/omni-core-ee Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36397/

Built to branch gh-pages at 2025-08-14 16:00 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

❌ Patch coverage is 69.06780% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.10%. Comparing base (ae48139) to head (4580374).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36397      +/-   ##
===========================================
+ Coverage    66.07%   66.10%   +0.02%     
===========================================
  Files         3293     3298       +5     
  Lines       110665   110868     +203     
  Branches     20994    21030      +36     
===========================================
+ Hits         73124    73291     +167     
- Misses       34869    34905      +36     
  Partials      2672     2672              
Flag Coverage Δ
e2e 57.28% <68.88%> (-0.01%) ⬇️
unit 71.42% <69.10%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gabriellsh gabriellsh marked this pull request as ready for review July 14, 2025 22:13
@gabriellsh gabriellsh requested a review from a team as a code owner July 14, 2025 22:13
@gabriellsh gabriellsh added this to the 7.9.0 milestone Jul 14, 2025
@scuciatto scuciatto modified the milestones: 7.9.0, 7.10.0 Jul 22, 2025
tassoevan
tassoevan previously approved these changes Aug 20, 2025
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Aug 20, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 20, 2025
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Aug 21, 2025
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Aug 21, 2025

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@dougfabris dougfabris added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Aug 22, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 22, 2025
@kodiakhq kodiakhq bot merged commit c6ef437 into develop Aug 22, 2025
52 checks passed
@kodiakhq kodiakhq bot deleted the voip/permissionFlow branch August 22, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants