-
Notifications
You must be signed in to change notification settings - Fork 13k
feat: Voice call device permission flow #36397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 4580374 The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #36397 +/- ##
===========================================
+ Coverage 66.07% 66.10% +0.02%
===========================================
Files 3293 3298 +5
Lines 110665 110868 +203
Branches 20994 21030 +36
===========================================
+ Hits 73124 73291 +167
- Misses 34869 34905 +36
Partials 2672 2672
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
Proposed changes (including videos or screenshots)
This pull request solves a few issues related to the device permission & device change menu. Notable fixes:
This PR also introduces new modals to increase information context when requesting permissions:
The new modals also prevent the call being automatically rejected when microphone permission was blocked, by forcing the user to either reject the call or grant the permission.
Issue(s)
VAI-62
Steps to test or reproduce
Further comments