Skip to content

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 9, 2025

required changes to prevent cyclic typing references
noticed here: #36146 during a new endpoint creation

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 9, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.9.0, but it targets 7.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2025

⚠️ No Changeset found

Latest commit: c518dc1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36388/

Built to branch gh-pages at 2025-07-11 13:25 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.76%. Comparing base (9adebfa) to head (c518dc1).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #36388   +/-   ##
========================================
  Coverage    64.75%   64.76%           
========================================
  Files         3156     3156           
  Lines       104912   104912           
  Branches     19958    19963    +5     
========================================
+ Hits         67937    67947   +10     
+ Misses       34286    34279    -7     
+ Partials      2689     2686    -3     
Flag Coverage Δ
e2e 57.60% <ø> (-0.02%) ⬇️
unit 69.48% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo added this to the 7.9.0 milestone Jul 9, 2025
@ggazzo ggazzo marked this pull request as ready for review July 9, 2025 17:25
@cardoso cardoso added the stat: QA assured Means it has been tested and approved by a company insider label Jul 11, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 11, 2025
@ggazzo ggazzo merged commit b10ce3b into develop Jul 11, 2025
22 checks passed
@ggazzo ggazzo deleted the chore/improve-route-typings branch July 11, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants