fix: executeSaveUserProfile does not trigger username stream
#36385
+16
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: f0b1bbb The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36385 +/- ##
===========================================
+ Coverage 64.74% 64.76% +0.01%
===========================================
Files 3156 3156
Lines 104916 104909 -7
Branches 19960 19963 +3
===========================================
+ Hits 67929 67940 +11
+ Misses 34298 34283 -15
+ Partials 2689 2686 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ggazzo
force-pushed
the
fix/set-username-react
branch
from
ee409b7 to
7547ece
Compare
pierre-lehnen-rc
requested changes
Jul 9, 2025
pierre-lehnen-rc
approved these changes
Jul 9, 2025
ggazzo
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Member
Author
|
/patch |
dionisio-bot bot
pushed a commit
that referenced
this pull request
Jul 15, 2025
Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com>
Contributor
|
Pull request #36430 added to Project: "Patch 7.8.1" |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rocketchat.atlassian.net/browse/ARCH-1701
if backporting: algo pick #36389
While replacing methods to use endpoints (#36146) , I noticed that some rest apis use slightly different methods, which end up not informing the UI
This pull request includes changes to improve user management functionality by refining the
setUsernameandsaveUserProfilemethods. The changes focus on removing unused imports, simplifying code, and adding a notification mechanism for user updates.Changes to
setUsernamefunctionality:RateLimiterwrapper and associated permissions check from thesetUsernamefunction to simplify its implementation. (apps/meteor/app/lib/server/functions/setUsername.ts, apps/meteor/app/lib/server/functions/setUsername.tsL154-L160)RateLimiterandhasPermissionAsyncand movingsettingsto a more relevant location. (apps/meteor/app/lib/server/functions/setUsername.ts, [1] [2]Changes to
saveUserProfilefunctionality:notifyOnUserChangeto trigger notifications when a user's profile is updated, improving real-time synchronization of user changes. (apps/meteor/server/methods/saveUserProfile.ts, apps/meteor/server/methods/saveUserProfile.tsR162-R164)notifyOnUserChangeimport to support the new notification mechanism. (apps/meteor/server/methods/saveUserProfile.ts, apps/meteor/server/methods/saveUserProfile.tsR13)Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments