Skip to content

Conversation

@jessicaschelly
Copy link
Member

@jessicaschelly jessicaschelly commented Jul 8, 2025

Proposed changes (including videos or screenshots)

This PR fixes and adds end-to-end tests for the user-required password change functionality. The implementation includes:

Bug fixes:

  • Redirect on Required Password Change: Sends notification to client

Test Coverage Added:

  • Password Change Required Flow: Tests for users who must change their password on first login
  • Password Change Not Required Flow: Tests for users who can login normally without password change
  • Error Handling: Tests for various error scenarios including:
    • Password confirmation mismatch
    • Attempting to use the same password as current
    • Form validation errors

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 8, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.9.0, but it targets 7.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 8, 2025

🦋 Changeset detected

Latest commit: 26e64b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36381/

Built to branch gh-pages at 2025-07-10 20:09 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.78%. Comparing base (2cec8ac) to head (26e64b6).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36381      +/-   ##
===========================================
+ Coverage    64.74%   64.78%   +0.03%     
===========================================
  Files         3156     3156              
  Lines       104912   104912              
  Branches     19961    19967       +6     
===========================================
+ Hits         67928    67963      +35     
+ Misses       34294    34264      -30     
+ Partials      2690     2685       -5     
Flag Coverage Δ
e2e 57.60% <ø> (+0.02%) ⬆️
unit 69.51% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jessicaschelly jessicaschelly changed the title test: add e2e test for required password change flow test: add tests for required password change flow Jul 8, 2025
@cardoso cardoso marked this pull request as ready for review July 10, 2025 16:57
@cardoso cardoso requested a review from a team as a code owner July 10, 2025 16:57
@cardoso cardoso requested a review from a team as a code owner July 10, 2025 19:45
@cardoso cardoso changed the title test: add tests for required password change flow fix: redirect on required password change Jul 10, 2025
@ggazzo ggazzo added this to the 7.9.0 milestone Jul 11, 2025
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jul 11, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 11, 2025
@kodiakhq kodiakhq bot merged commit 9adebfa into develop Jul 11, 2025
89 of 91 checks passed
@kodiakhq kodiakhq bot deleted the test/require-password-change branch July 11, 2025 13:06
@ggazzo
Copy link
Member

ggazzo commented Jul 15, 2025

/patch

@ggazzo
Copy link
Member

ggazzo commented Jul 15, 2025

/backport 7.7.5

dionisio-bot bot pushed a commit that referenced this pull request Jul 15, 2025
Co-authored-by: Matheus Cardoso <5606812+cardoso@users.noreply.github.com>
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 15, 2025

Pull request #36432 added to Project: "Patch 7.8.1"

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 15, 2025

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-7.7.5-36381
git cherry-pick 9adebfa02dd0618b4b070c42f24fd7ca6d957e0e
// solve the conflict
git push

after that just run /backport 7.7.5 again

ggazzo pushed a commit that referenced this pull request Jul 16, 2025
Co-authored-by: Matheus Cardoso <5606812+cardoso@users.noreply.github.com>
@ggazzo
Copy link
Member

ggazzo commented Jul 16, 2025

/backport 7.7.5

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 16, 2025

Pull request #36437 added to Project: "Patch 7.7.5"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants