Skip to content

Conversation

@lucas-a-pelegrino
Copy link
Contributor

@lucas-a-pelegrino lucas-a-pelegrino commented Jul 7, 2025

Proposed changes (including videos or screenshots)

Implement new API endpoints to allow for listing currently listed providers and fetch provider metadata.

GET /api/v1/omnichannel/outbound/providers:

Endpoint should be filterable by provider type → phone | email

The endpoint should return all providers currently registered for the given type.

GET /api/v1/omnichannel/outbound/providers/:id/metadata: (Needs Apps bridge to work)

Endpoint should return the specified provider’s metadata

:id → appId

Issue(s)

https://rocketchat.atlassian.net/browse/CTZ-182
https://rocketchat.atlassian.net/browse/CTZ-214

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 7, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.9.0, but it targets 7.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2025

🦋 Changeset detected

Latest commit: 6cbd5fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/apps-engine Minor
@rocket.chat/core-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/rest-typings Minor
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/gazzodown Major
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/models Patch
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36377/

Built to branch gh-pages at 2025-07-10 12:50 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.76%. Comparing base (7d15361) to head (6cbd5fd).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36377      +/-   ##
===========================================
+ Coverage    64.75%   64.76%   +0.01%     
===========================================
  Files         3156     3156              
  Lines       104909   104912       +3     
  Branches     19959    19970      +11     
===========================================
+ Hits         67936    67950      +14     
+ Misses       34288    34278      -10     
+ Partials      2685     2684       -1     
Flag Coverage Δ
e2e 57.55% <ø> (-0.02%) ⬇️
unit 69.51% <60.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KevLehman KevLehman marked this pull request as ready for review July 8, 2025 19:56
@KevLehman KevLehman requested review from a team as code owners July 8, 2025 19:56
KevLehman
KevLehman previously approved these changes Jul 8, 2025
KevLehman
KevLehman previously approved these changes Jul 8, 2025
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Jul 8, 2025
@KevLehman KevLehman added this to the 7.9.0 milestone Jul 8, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 8, 2025
d-gubert
d-gubert previously approved these changes Jul 8, 2025
@KevLehman KevLehman dismissed stale reviews from d-gubert, aleksandernsilva, and themself via a7c4892 July 9, 2025 13:18
@kodiakhq kodiakhq bot merged commit 2cec8ac into develop Jul 10, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the feat/CTZ-182 branch July 10, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants