Skip to content

Conversation

@aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Jul 4, 2025

Proposed changes (including videos or screenshots)

This PR enhances the user experience of the AutoCompleteDepartment component during its loading phase.

  • Prevents user interaction: The field is now disabled while fetching data.
  • Improves feedback: A "Loading..." placeholder text is shown.
  • Improves accessibility: The aria-busy="true" attribute is added to inform screen readers that the component is loading.

Issue(s)

CTZ-194

Steps to test or reproduce

  • Navigate to one of the following pages:
    • Analytics
    • Canned Responses
    • Edit Department
  • Open your browser's Developer Tools and go to the "Network" tab.
  • Throttle the connection speed (e.g., to "Slow 3G").
  • Refresh the page or interact with the AutoCompleteDepartment component.
  • The component should appear disabled with a "Loading..." placeholder text.

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 4, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.9.0, but it targets 7.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 4, 2025

🦋 Changeset detected

Latest commit: 2159295

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36364/

Built to branch gh-pages at 2025-07-04 17:54 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.95%. Comparing base (459f635) to head (2159295).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36364      +/-   ##
===========================================
+ Coverage    64.92%   64.95%   +0.03%     
===========================================
  Files         3156     3156              
  Lines       104828   104894      +66     
  Branches     19924    19931       +7     
===========================================
+ Hits         68057    68139      +82     
+ Misses       34087    34071      -16     
  Partials      2684     2684              
Flag Coverage Δ
e2e 57.74% <66.66%> (+0.04%) ⬆️
e2e-api 35.57% <ø> (-0.05%) ⬇️
unit 69.77% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aleksandernsilva aleksandernsilva marked this pull request as ready for review July 4, 2025 19:21
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner July 4, 2025 19:21
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Jul 7, 2025
@aleksandernsilva aleksandernsilva added this to the 7.9.0 milestone Jul 7, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 7, 2025
@kodiakhq kodiakhq bot merged commit 96fa731 into develop Jul 7, 2025
51 checks passed
@kodiakhq kodiakhq bot deleted the feat/autocomplete-department-loading branch July 7, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants