-
Notifications
You must be signed in to change notification settings - Fork 13k
feat: Improve AutoCompleteDepartment loading state #36364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 2159295 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36364 +/- ##
===========================================
+ Coverage 64.92% 64.95% +0.03%
===========================================
Files 3156 3156
Lines 104828 104894 +66
Branches 19924 19931 +7
===========================================
+ Hits 68057 68139 +82
+ Misses 34087 34071 -16
Partials 2684 2684
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
This PR enhances the user experience of the AutoCompleteDepartment component during its loading phase.
aria-busy="true"attribute is added to inform screen readers that the component is loading.Issue(s)
CTZ-194
Steps to test or reproduce
Further comments