Skip to content

Conversation

@MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented Jul 3, 2025

Proposed changes (including videos or screenshots)

Screenshot 2025-07-10 at 12 56 26

Issue(s)

ALT-23

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 3, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 3, 2025

🦋 Changeset detected

Latest commit: 3fd05ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/i18n Minor
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/ui-voip Major
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/queue-worker Patch
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/http-router Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence-service Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36359/

Built to branch gh-pages at 2025-07-17 20:33 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 88.25758% with 31 lines in your changes missing coverage. Please review.

Project coverage is 65.66%. Comparing base (78ff5df) to head (3fd05ad).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36359      +/-   ##
===========================================
+ Coverage    65.58%   65.66%   +0.08%     
===========================================
  Files         3172     3176       +4     
  Lines       105484   105733     +249     
  Branches     20042    20082      +40     
===========================================
+ Hits         69180    69428     +248     
+ Misses       33629    33627       -2     
- Partials      2675     2678       +3     
Flag Coverage Δ
e2e 58.14% <21.95%> (-0.01%) ⬇️
unit 70.79% <87.45%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MartinSchoeler MartinSchoeler force-pushed the feat/app-instances-page branch from 3f52d04 to 9f3d47b Compare July 4, 2025 16:30
@MartinSchoeler MartinSchoeler force-pushed the feat/app-instances-page branch from 9f3d47b to 06902cc Compare July 4, 2025 16:44
@MartinSchoeler MartinSchoeler marked this pull request as ready for review July 8, 2025 17:27
@MartinSchoeler MartinSchoeler requested review from a team as code owners July 8, 2025 17:27
Copy link
Contributor

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a changeset?

tassoevan
tassoevan previously approved these changes Jul 12, 2025
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Jul 17, 2025
@MartinSchoeler MartinSchoeler added the stat: ready to merge PR tested and approved waiting for merge label Jul 17, 2025
@d-gubert d-gubert added this to the 7.9.0 milestone Jul 17, 2025
@kodiakhq kodiakhq bot merged commit 3f000d7 into develop Jul 17, 2025
87 of 89 checks passed
@kodiakhq kodiakhq bot deleted the feat/app-instances-page branch July 17, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants