Skip to content

Conversation

@d-gubert
Copy link
Member

@d-gubert d-gubert commented Jul 2, 2025

Proposed changes (including videos or screenshots)

Deno runtime was inconsistently handling the propagation of error objects when it received an error response from JsonRPC.

Now apps will always receive instances of Error if their accessor method calls fail.

Issue(s)

Steps to test or reproduce

Further comments

SUP-823

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 2, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.9.0, but it targets 7.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2025

🦋 Changeset detected

Latest commit: d673b5e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/apps-engine Patch
@rocket.chat/meteor Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/core-typings Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36346/

Built to branch gh-pages at 2025-07-03 16:50 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.92%. Comparing base (92848ce) to head (d673b5e).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36346      +/-   ##
===========================================
- Coverage    64.92%   64.92%   -0.01%     
===========================================
  Files         3156     3156              
  Lines       104827   104827              
  Branches     19930    19928       -2     
===========================================
- Hits         68063    68062       -1     
- Misses       34078    34081       +3     
+ Partials      2686     2684       -2     
Flag Coverage Δ
e2e 57.69% <ø> (ø)
unit 69.74% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@d-gubert d-gubert force-pushed the fix/apps-error-responses branch 2 times, most recently from 88d7b53 to bc16472 Compare July 2, 2025 19:50
@d-gubert d-gubert marked this pull request as ready for review July 3, 2025 12:58
@d-gubert d-gubert requested a review from a team as a code owner July 3, 2025 12:58
@d-gubert d-gubert marked this pull request as draft July 3, 2025 12:58
@d-gubert d-gubert marked this pull request as ready for review July 3, 2025 14:06
@d-gubert d-gubert force-pushed the fix/apps-error-responses branch from b6eec5b to d673b5e Compare July 3, 2025 16:46
@ggazzo ggazzo added this to the 7.9.0 milestone Jul 3, 2025
@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Jul 4, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 4, 2025
@kodiakhq kodiakhq bot merged commit 9826bc2 into develop Jul 4, 2025
51 checks passed
@kodiakhq kodiakhq bot deleted the fix/apps-error-responses branch July 4, 2025 12:21
@d-gubert
Copy link
Member Author

d-gubert commented Jul 4, 2025

/patch

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 4, 2025

    Sorry, I couldn't do that backport because of conflicts. Could you please solve them?
    
    you can do so by running the following commands:
git fetch
git checkout backport-7.7.4-36346
git cherry-pick 9826bc2ed9a3a4232ce6d5d436c3f489f2d4192b
// solve the conflict
git push

after that just run /patch again

@d-gubert
Copy link
Member Author

d-gubert commented Jul 4, 2025

/patch

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 4, 2025

Pull request #36360 added to Project: "Patch 7.7.4"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants