-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: properly throw error objects to apps on runtime #36346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: d673b5e The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36346 +/- ##
===========================================
- Coverage 64.92% 64.92% -0.01%
===========================================
Files 3156 3156
Lines 104827 104827
Branches 19930 19928 -2
===========================================
- Hits 68063 68062 -1
- Misses 34078 34081 +3
+ Partials 2686 2684 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
88d7b53 to
bc16472
Compare
b6eec5b to
d673b5e
Compare
|
/patch |
after that just run |
|
/patch |
|
Pull request #36360 added to Project: "Patch 7.7.4" |
Proposed changes (including videos or screenshots)
Deno runtime was inconsistently handling the propagation of error objects when it received an error response from JsonRPC.
Now apps will always receive instances of
Errorif their accessor method calls fail.Issue(s)
Steps to test or reproduce
Further comments
SUP-823