Skip to content

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 2, 2025

https://rocketchat.atlassian.net/browse/ARCH-1696

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 2, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.9.0, but it targets 7.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2025

⚠️ No Changeset found

Latest commit: d7b8771

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36342/

Built to branch gh-pages at 2025-07-02 00:40 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.79%. Comparing base (d4226a5) to head (d7b8771).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #36342   +/-   ##
========================================
  Coverage    64.79%   64.79%           
========================================
  Files         3153     3153           
  Lines       104876   104876           
  Branches     19985    19987    +2     
========================================
+ Hits         67955    67959    +4     
+ Misses       34242    34234    -8     
- Partials      2679     2683    +4     
Flag Coverage Δ
e2e 57.72% <ø> (+0.01%) ⬆️
unit 69.52% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo added this to the 7.9.0 milestone Jul 2, 2025
@ggazzo ggazzo marked this pull request as ready for review July 2, 2025 01:08
@ggazzo ggazzo requested a review from a team as a code owner July 2, 2025 01:08
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jul 2, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 2, 2025
@kodiakhq kodiakhq bot merged commit c006921 into develop Jul 2, 2025
89 of 91 checks passed
@kodiakhq kodiakhq bot deleted the ci/bump-keys branch July 2, 2025 02:43
@ggazzo
Copy link
Member Author

ggazzo commented Jul 2, 2025

/patch

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 2, 2025

    Sorry, I couldn't do that backport because of conflicts. Could you please solve them?
    
    you can do so by running the following commands:
git fetch
git checkout backport-7.7.3-36342
git cherry-pick c00692115a7f76eb630569b8caabc3d19b59acf8
// solve the conflict
git push

after that just run /patch again

ggazzo added a commit that referenced this pull request Jul 2, 2025
@ggazzo
Copy link
Member Author

ggazzo commented Jul 2, 2025

/patch

@dionisio-bot dionisio-bot bot mentioned this pull request Jul 2, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 2, 2025

Pull request #36344 added to Project: "Patch 7.7.3"

ggazzo added a commit that referenced this pull request Jul 2, 2025
sem22-dev pushed a commit to sem22-dev/Rocket.Chat that referenced this pull request Jul 4, 2025
@julio-rocketchat
Copy link
Member

/backport 7.6.4

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 4, 2025

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-7.6.4-36342
git cherry-pick c00692115a7f76eb630569b8caabc3d19b59acf8
// solve the conflict
git push

after that just run /backport 7.6.4 again

julio-rocketchat pushed a commit that referenced this pull request Jul 4, 2025
@julio-rocketchat
Copy link
Member

/backport 7.6.4

@dionisio-bot dionisio-bot bot mentioned this pull request Jul 4, 2025
@julio-rocketchat
Copy link
Member

/backport 7.5.3

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 4, 2025

Pull request #36365 added to Project: "Patch 7.6.4"

dionisio-bot bot pushed a commit that referenced this pull request Jul 4, 2025
@dionisio-bot dionisio-bot bot mentioned this pull request Jul 4, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 4, 2025

Pull request #36366 added to Project: "Patch 7.5.3"

@julio-rocketchat
Copy link
Member

/backport 7.4.4

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 4, 2025

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-7.4.4-36342
git cherry-pick c00692115a7f76eb630569b8caabc3d19b59acf8
// solve the conflict
git push

after that just run /backport 7.4.4 again

julio-rocketchat pushed a commit that referenced this pull request Jul 4, 2025
@julio-rocketchat
Copy link
Member

/backport 7.4.4

@dionisio-bot dionisio-bot bot mentioned this pull request Jul 4, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 4, 2025

Pull request #36367 added to Project: "Patch 7.4.4"

@julio-rocketchat
Copy link
Member

/backport 7.3.6

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 4, 2025

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-7.3.6-36342
git cherry-pick c00692115a7f76eb630569b8caabc3d19b59acf8
// solve the conflict
git push

after that just run /backport 7.3.6 again

julio-rocketchat pushed a commit that referenced this pull request Jul 4, 2025
@julio-rocketchat
Copy link
Member

/backport 7.3.6

@dionisio-bot dionisio-bot bot mentioned this pull request Jul 4, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 4, 2025

Pull request #36368 added to Project: "Patch 7.3.6"

MartinSchoeler pushed a commit that referenced this pull request Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants