Skip to content

Conversation

@tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Jun 27, 2025

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-1228

Steps to test or reproduce

Further comments

@tiagoevanp tiagoevanp requested a review from a team as a code owner June 27, 2025 14:14
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 27, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2025

⚠️ No Changeset found

Latest commit: c1f163c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36319/

Built to branch gh-pages at 2025-07-17 16:59 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.60%. Comparing base (9f3c11c) to head (c1f163c).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36319      +/-   ##
===========================================
+ Coverage    65.57%   65.60%   +0.03%     
===========================================
  Files         3172     3172              
  Lines       105477   105484       +7     
  Branches     20042    20048       +6     
===========================================
+ Hits         69171    69208      +37     
+ Misses       33622    33603      -19     
+ Partials      2684     2673      -11     
Flag Coverage Δ
e2e 58.17% <100.00%> (+0.02%) ⬆️
unit 70.73% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tiagoevanp tiagoevanp force-pushed the regression/file-pdf-export branch from 0655d1f to a456184 Compare June 27, 2025 18:05
@tiagoevanp tiagoevanp added this to the 7.9.0 milestone Jul 2, 2025
Copy link
Member

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we take the opportunity to create some tests for these select variations? We could either extend the existing e2e tests or maybe create a unit test from the existing storybook

@scuciatto scuciatto requested a review from MartinSchoeler July 16, 2025 10:42
MartinSchoeler
MartinSchoeler previously approved these changes Jul 16, 2025
@tiagoevanp tiagoevanp added the stat: QA assured Means it has been tested and approved by a company insider label Jul 16, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 16, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jul 16, 2025
@tiagoevanp tiagoevanp added the stat: ready to merge PR tested and approved waiting for merge label Jul 16, 2025
@tiagoevanp tiagoevanp force-pushed the regression/file-pdf-export branch from 4ff8bb8 to 3827312 Compare July 16, 2025 19:34
@kodiakhq kodiakhq bot merged commit 0d45149 into develop Jul 17, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the regression/file-pdf-export branch July 17, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants