-
Notifications
You must be signed in to change notification settings - Fork 13.1k
regression: Remove pdf option in export messages as file #36319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36319 +/- ##
===========================================
+ Coverage 65.57% 65.60% +0.03%
===========================================
Files 3172 3172
Lines 105477 105484 +7
Branches 20042 20048 +6
===========================================
+ Hits 69171 69208 +37
+ Misses 33622 33603 -19
+ Partials 2684 2673 -11
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
0655d1f to
a456184
Compare
MartinSchoeler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we take the opportunity to create some tests for these select variations? We could either extend the existing e2e tests or maybe create a unit test from the existing storybook
4ff8bb8 to
3827312
Compare
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-1228
Steps to test or reproduce
Further comments