Skip to content

Conversation

@ahmed-n-abdeltwab
Copy link
Contributor

@ahmed-n-abdeltwab ahmed-n-abdeltwab commented Jun 27, 2025

description:

Change the ExtractValidation type to return 'unknown' instead of 'never' for the case where the params return never'. Instead of never, unknown should be good.

Tests:

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 27, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.9.0, but it targets 7.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2025

⚠️ No Changeset found

Latest commit: 1abd4cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cardoso cardoso added this to the 7.9.0 milestone Jun 27, 2025
@ahmed-n-abdeltwab ahmed-n-abdeltwab force-pushed the refactor/api-extract-validation-definition branch from 3f15b10 to 0a587a3 Compare June 28, 2025 05:35
@ahmed-n-abdeltwab ahmed-n-abdeltwab force-pushed the refactor/api-extract-validation-definition branch from d405d25 to cd8c5da Compare June 28, 2025 05:49
@ahmed-n-abdeltwab
Copy link
Contributor Author

ahmed-n-abdeltwab commented Jun 28, 2025

This is also an issue with POST; perhaps changes could also be made to POST, PUT, etc.

@cardoso cardoso added the stat: QA assured Means it has been tested and approved by a company insider label Jun 29, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 29, 2025
@kodiakhq kodiakhq bot merged commit cac1463 into RocketChat:develop Jun 29, 2025
154 of 167 checks passed
sem22-dev pushed a commit to sem22-dev/Rocket.Chat that referenced this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gsoc-project stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants