-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: REST api v1 not enforcing rate limiter #36313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: d812c90 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36313 +/- ##
===========================================
+ Coverage 65.50% 65.52% +0.01%
===========================================
Files 3169 3169
Lines 105177 105187 +10
Branches 20029 20038 +9
===========================================
+ Hits 68896 68920 +24
+ Misses 33602 33591 -11
+ Partials 2679 2676 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
5fd2389 to
99c0b4d
Compare
Proposed changes (including videos or screenshots)
This PR fixes the issue of Rate Limiter not being enforced. Rate-limit rules are defined with version prefixed paths (e.g. /v1/rooms.get), but the limiter was receiving malformed keys like /rooms.getget, so no v1 endpoints were ever rate-limited.
Since, the lookup for the current route in the rateLimiter config dictionary always failed.
getFullRouteName()a public method onAPIClass.Issue(s)
CORE-1236
Steps to test or reproduce
Further comments