Skip to content

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Jun 23, 2025

https://rocketchat.atlassian.net/browse/ARCH-1679

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 23, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.9.0, but it targets 7.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2025

⚠️ No Changeset found

Latest commit: 561562d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36286/

Built to branch gh-pages at 2025-06-23 20:13 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.84%. Comparing base (10a2f6e) to head (561562d).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36286      +/-   ##
===========================================
+ Coverage    64.81%   64.84%   +0.02%     
===========================================
  Files         3153     3153              
  Lines       104789   104787       -2     
  Branches     19957    19960       +3     
===========================================
+ Hits         67920    67945      +25     
+ Misses       34182    34154      -28     
- Partials      2687     2688       +1     
Flag Coverage Δ
e2e 57.67% <100.00%> (+0.06%) ⬆️
unit 69.61% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo added this to the 7.9.0 milestone Jun 23, 2025
@ggazzo ggazzo marked this pull request as ready for review June 23, 2025 21:08
@ggazzo ggazzo requested a review from a team as a code owner June 23, 2025 21:08
Copy link
Contributor

@juliajforesti juliajforesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@juliajforesti juliajforesti added the stat: QA assured Means it has been tested and approved by a company insider label Jun 23, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 23, 2025
@kodiakhq kodiakhq bot merged commit dd20d85 into develop Jun 23, 2025
52 checks passed
@kodiakhq kodiakhq bot deleted the chore/reactive-query branch June 23, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants