Skip to content

Conversation

@juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Jun 23, 2025

ARCH-1666

Proposed changes (including videos or screenshots)

replace Minimongo collection for Roles with Zustand store

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 23, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.9.0, but it targets 7.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2025

⚠️ No Changeset found

Latest commit: 3bc880f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36282/

Built to branch gh-pages at 2025-06-23 17:57 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 64.84%. Comparing base (10a2f6e) to head (3bc880f).
Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36282      +/-   ##
===========================================
+ Coverage    64.81%   64.84%   +0.02%     
===========================================
  Files         3153     3153              
  Lines       104789   104792       +3     
  Branches     19957    19976      +19     
===========================================
+ Hits         67920    67951      +31     
+ Misses       34182    34151      -31     
- Partials      2687     2690       +3     
Flag Coverage Δ
e2e 57.70% <57.14%> (+0.10%) ⬆️
unit 69.61% <63.63%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juliajforesti juliajforesti marked this pull request as ready for review June 24, 2025 18:17
@juliajforesti juliajforesti requested a review from a team as a code owner June 24, 2025 18:17
@juliajforesti juliajforesti added this to the 7.9.0 milestone Jun 24, 2025
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jun 24, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 24, 2025
@ggazzo ggazzo merged commit c00730e into develop Jun 24, 2025
73 of 75 checks passed
@ggazzo ggazzo deleted the chore/roles-store branch June 24, 2025 18:36
ahmed-n-abdeltwab pushed a commit to ahmed-n-abdeltwab/Rocket.Chat that referenced this pull request Jun 26, 2025
sem22-dev pushed a commit to sem22-dev/Rocket.Chat that referenced this pull request Jul 4, 2025
MartinSchoeler pushed a commit that referenced this pull request Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants