-
Notifications
You must be signed in to change notification settings - Fork 13k
chore: Use useButtonPattern instead of manual key check
#36277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #36277 +/- ##
===========================================
- Coverage 64.84% 64.81% -0.03%
===========================================
Files 3153 3153
Lines 104792 104812 +20
Branches 19964 19969 +5
===========================================
- Hits 67950 67933 -17
- Misses 34153 34190 +37
Partials 2689 2689
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
useButtonPattern hook instead of manual key checkuseButtonPattern instead of manual key check
Proposed changes (including videos or screenshots)
It uses the
useButtonPatternwhere we do manual key checking when we want button behavior for elements that is not abuttonelementIssue(s)
Steps to test or reproduce
Further comments
ARCH-1667