Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Jun 23, 2025

Proposed changes (including videos or screenshots)

It uses the useButtonPattern where we do manual key checking when we want button behavior for elements that is not a button element

Issue(s)

Steps to test or reproduce

Further comments

ARCH-1667

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 23, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.9.0, but it targets 7.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2025

⚠️ No Changeset found

Latest commit: 3732927

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 7.9.0 milestone Jun 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36277/

Built to branch gh-pages at 2025-06-24 21:48 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 64.81%. Comparing base (c00730e) to head (3732927).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36277      +/-   ##
===========================================
- Coverage    64.84%   64.81%   -0.03%     
===========================================
  Files         3153     3153              
  Lines       104792   104812      +20     
  Branches     19964    19969       +5     
===========================================
- Hits         67950    67933      -17     
- Misses       34153    34190      +37     
  Partials      2689     2689              
Flag Coverage Δ
e2e 57.66% <80.00%> (-0.05%) ⬇️
unit 69.56% <75.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris changed the title chore: Use useButtonPattern hook instead of manual key check chore: Use useButtonPattern instead of manual key check Jun 23, 2025
@dougfabris dougfabris marked this pull request as ready for review June 23, 2025 18:15
@dougfabris dougfabris requested a review from a team as a code owner June 23, 2025 18:15
@dougfabris dougfabris requested a review from gabriellsh June 23, 2025 23:09
@gabriellsh gabriellsh added the stat: QA assured Means it has been tested and approved by a company insider label Jun 24, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 24, 2025
@kodiakhq kodiakhq bot merged commit 542971f into develop Jun 24, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the chore/useButtonPattern branch June 24, 2025 22:33
ahmed-n-abdeltwab pushed a commit to ahmed-n-abdeltwab/Rocket.Chat that referenced this pull request Jun 26, 2025
sem22-dev pushed a commit to sem22-dev/Rocket.Chat that referenced this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants