Skip to content

Conversation

@d-gubert
Copy link
Member

@d-gubert d-gubert commented Jun 18, 2025

Proposed changes (including videos or screenshots)

Add the endpoint /api/apps/:id/logs/distinctValues that returns an array of the distinct values of the instanceId and method fields found in the logs collection.

This will assist filtering UI capabilities

Issue(s)

Steps to test or reproduce

Further comments

ALT-21
ALT-25

Not adding a changeset file as this is mainly a complement for #36288

Will need to document the "deprecated" indexes until we're able to delete them with a migration on 8.0

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 18, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 18, 2025

⚠️ No Changeset found

Latest commit: a349664

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@d-gubert
Copy link
Member Author

I'm pondering whether to add a changeset for this one. The main purpose of the endpoint is to assist the UI with pre-populated filtering data, there is not much use beyond that - thus my doubt if it deserves to be in the changeset by itself, or if we leave the changeset to be added by the filters PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36245/

Built to branch gh-pages at 2025-07-18 13:07 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 96.10390% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.71%. Comparing base (415d7c3) to head (a349664).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36245      +/-   ##
===========================================
+ Coverage    65.69%   65.71%   +0.02%     
===========================================
  Files         3171     3173       +2     
  Lines       105625   105659      +34     
  Branches     20057    20066       +9     
===========================================
+ Hits         69386    69433      +47     
+ Misses       33562    33547      -15     
- Partials      2677     2679       +2     
Flag Coverage Δ
e2e 58.18% <17.39%> (+0.01%) ⬆️
unit 70.84% <96.10%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@d-gubert d-gubert force-pushed the feat/apps-logs-instanceId-index branch 3 times, most recently from 11bb294 to 4e30e03 Compare June 23, 2025 18:34
@d-gubert d-gubert added this to the 7.9.0 milestone Jun 23, 2025
@d-gubert d-gubert force-pushed the feat/apps-logs-instanceId-index branch from 4e30e03 to db859ca Compare June 25, 2025 11:03
@d-gubert d-gubert force-pushed the feat/apps-logs-instanceId-index branch 2 times, most recently from c4863b8 to 2e0e6ab Compare July 9, 2025 00:09
@d-gubert d-gubert changed the title feat: endpoint to fetch distinct instanceId for logs filter feat: endpoint to fetch distinct values for apps logs filter Jul 10, 2025
@d-gubert d-gubert force-pushed the feat/apps-logs-instanceId-index branch 7 times, most recently from ea41969 to 5867ed2 Compare July 16, 2025 19:39
@d-gubert d-gubert force-pushed the feat/apps-logs-instanceId-index branch from 268757f to 024d0c1 Compare July 16, 2025 22:11
@d-gubert d-gubert marked this pull request as ready for review July 17, 2025 04:05
@d-gubert d-gubert requested review from a team as code owners July 17, 2025 04:05
@d-gubert d-gubert requested a review from MartinSchoeler July 17, 2025 04:06
MartinSchoeler
MartinSchoeler previously approved these changes Jul 17, 2025
@d-gubert d-gubert force-pushed the feat/apps-logs-instanceId-index branch from 235b4bf to 3c0c9cd Compare July 17, 2025 13:51
MartinSchoeler
MartinSchoeler previously approved these changes Jul 17, 2025
@d-gubert d-gubert dismissed stale reviews from MartinSchoeler and MarcosSpessatto via a349664 July 18, 2025 12:57
@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Jul 18, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 18, 2025
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving in respect to the approvals of my friends who are enjoying their well-deserved rest

@ggazzo ggazzo merged commit a1ac925 into develop Jul 18, 2025
51 checks passed
@ggazzo ggazzo deleted the feat/apps-logs-instanceId-index branch July 18, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants