-
Notifications
You must be signed in to change notification settings - Fork 13k
feat: endpoint to fetch distinct values for apps logs filter #36245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
|
I'm pondering whether to add a changeset for this one. The main purpose of the endpoint is to assist the UI with pre-populated filtering data, there is not much use beyond that - thus my doubt if it deserves to be in the changeset by itself, or if we leave the changeset to be added by the filters PR |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #36245 +/- ##
===========================================
+ Coverage 65.69% 65.71% +0.02%
===========================================
Files 3171 3173 +2
Lines 105625 105659 +34
Branches 20057 20066 +9
===========================================
+ Hits 69386 69433 +47
+ Misses 33562 33547 -15
- Partials 2677 2679 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
11bb294 to
4e30e03
Compare
4e30e03 to
db859ca
Compare
c4863b8 to
2e0e6ab
Compare
ea41969 to
5867ed2
Compare
apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppLogs/Filters/AppLogsFilter.tsx
Outdated
Show resolved
Hide resolved
268757f to
024d0c1
Compare
…gs/Filters/AppLogsFilter.tsx Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat>
235b4bf to
3c0c9cd
Compare
a349664
ggazzo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving in respect to the approvals of my friends who are enjoying their well-deserved rest
Proposed changes (including videos or screenshots)
Add the endpoint
/api/apps/:id/logs/distinctValuesthat returns an array of the distinct values of theinstanceIdandmethodfields found in the logs collection.This will assist filtering UI capabilities
Issue(s)
Steps to test or reproduce
Further comments
ALT-21
ALT-25
Not adding a changeset file as this is mainly a complement for #36288
Will need to document the "deprecated" indexes until we're able to delete them with a migration on 8.0