-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: LDAP Sync sending repeated deactivation emails to inactive users #36235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: a622fae The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36235 +/- ##
========================================
Coverage 64.83% 64.84%
========================================
Files 3153 3153
Lines 104795 104795
Branches 19960 19965 +5
========================================
+ Hits 67946 67951 +5
+ Misses 34165 34158 -7
- Partials 2684 2686 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
When the LDAP sync process tries to deactivate an user that is no longer found on LDAP, it does so even if the user was already inactive on Rocket.Chat. This was causing Rocket.Chat to send repeated Deactivation Emails to those users, whenever the sync process ran.
Issue(s)
SUP-805
Steps to test or reproduce
Further comments