-
Notifications
You must be signed in to change notification settings - Fork 13k
chore: add missing dependency link (omnichannel-services -> i18n) #36233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36233 +/- ##
===========================================
- Coverage 64.79% 64.78% -0.02%
===========================================
Files 3153 3153
Lines 104875 104861 -14
Branches 19987 19977 -10
===========================================
- Hits 67956 67929 -27
- Misses 34245 34247 +2
- Partials 2674 2685 +11
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
4a46f9f
Proposed changes (including videos or screenshots)
The
omnichannel-servicespackages imports@rocket.chat/i18n, but doesn't list it as a dependency. This causesyarn buildto fail if it tried to build both packages at the same time (which naturally would only happen when most packages are already cached but@rocket.chat/toolsisn't)Issue(s)
Steps to test or reproduce
Further comments