Skip to content

Conversation

@pierre-lehnen-rc
Copy link
Contributor

Proposed changes (including videos or screenshots)

The omnichannel-services packages imports @rocket.chat/i18n, but doesn't list it as a dependency. This causes yarn build to fail if it tried to build both packages at the same time (which naturally would only happen when most packages are already cached but @rocket.chat/tools isn't)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 17, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.9.0, but it targets 7.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2025

⚠️ No Changeset found

Latest commit: a1857b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review June 17, 2025 16:19
@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36233/

Built to branch gh-pages at 2025-06-30 14:10 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.78%. Comparing base (cac1463) to head (a1857b7).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36233      +/-   ##
===========================================
- Coverage    64.79%   64.78%   -0.02%     
===========================================
  Files         3153     3153              
  Lines       104875   104861      -14     
  Branches     19987    19977      -10     
===========================================
- Hits         67956    67929      -27     
- Misses       34245    34247       +2     
- Partials      2674     2685      +11     
Flag Coverage Δ
e2e 57.69% <ø> (+0.02%) ⬆️
unit 69.50% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

KevLehman
KevLehman previously approved these changes Jun 19, 2025
@ggazzo ggazzo added this to the 7.8.0 milestone Jun 20, 2025
@pierre-lehnen-rc pierre-lehnen-rc added the stat: QA assured Means it has been tested and approved by a company insider label Jun 20, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 20, 2025
@pierre-lehnen-rc pierre-lehnen-rc modified the milestones: 7.8.0, 7.9.0 Jun 24, 2025
@kodiakhq kodiakhq bot merged commit a4a0017 into develop Jun 30, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the chore/fix-i18n-dependency branch June 30, 2025 14:55
sem22-dev pushed a commit to sem22-dev/Rocket.Chat that referenced this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants