fix: Re-establish connection with FreeSwitch server when it is lost #36230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 612da48 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #36230 +/- ##
===========================================
- Coverage 64.83% 64.80% -0.03%
===========================================
Files 3153 3153
Lines 104815 104861 +46
Branches 19966 19990 +24
===========================================
+ Hits 67954 67955 +1
- Misses 34182 34222 +40
- Partials 2679 2684 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
pierre-lehnen-rc
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
MarcosSpessatto
approved these changes
Jun 26, 2025
KevLehman
approved these changes
Jun 26, 2025
sem22-dev
pushed a commit
to sem22-dev/Rocket.Chat
that referenced
this pull request
Jul 4, 2025
MartinSchoeler
pushed a commit
that referenced
this pull request
Jul 10, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
If the FreeSwitch service is restarted, or if the connection to it is lost or fails for any reason, Rocket.Chat was never trying to connect again.
I've replaced the
connectfunction that we were using to establish the connection with a custom class similar toesl's own Client, but with additional capabilities for reconnections. I also split it into two subclasses, one for connections that run api commands and another for connections that listens to event. This was done to reduce the number of events the instance will request of FreeSwitch, thus reducing the amount of data exchanged over the network for this persistent connection.Issue(s)
VSTAB-37
Steps to test or reproduce
Further comments