fix: VoIP widget mute action muting received audio instead of just microphone. #36229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 0ee5d55 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36229 +/- ##
========================================
Coverage 64.52% 64.53%
========================================
Files 3148 3148
Lines 104632 104632
Branches 19769 19802 +33
========================================
+ Hits 67519 67527 +8
+ Misses 34425 34418 -7
+ Partials 2688 2687 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
aleksandernsilva
approved these changes
Jun 20, 2025
gabriellsh
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
For some reason both
senderandreceivertracks were being muted simultaneously. The code was very similar to the "setHold" method, which does actually mute both users, as well as sends a message so that the peer client knows the call is on hold.In fact,
setMutewas also sending a "re-INVITE" for some reason. This is not necessary, as the peer client does not need to know if the other peer's microphone is muted or not. That information is only relevant for setting the call on hold.The fix removes this "re-invite" logic and simply mutes ONLY the sender tracks, disabling the mic, but keeping the received audio playing.
Issue(s)
VSTAB-26
Steps to test or reproduce
Tip: If testing locally with the same machine, you can mute the browser tab to figure out which user the audio is coming from.
Further comments