Skip to content

Conversation

@julio-rocketchat
Copy link
Member

@julio-rocketchat julio-rocketchat commented Jun 16, 2025

Proposed changes (including videos or screenshots)

  • This PR has already been approved in the private repo.

Issue(s)

VLN-121

Steps to test or reproduce

Further comments

---------

Co-authored-by: jonasflorencio <[email protected]>
Co-authored-by: Kevin Aleman <[email protected]>
@julio-rocketchat julio-rocketchat requested a review from a team as a code owner June 16, 2025 13:56
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 16, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2025

🦋 Changeset detected

Latest commit: d657301

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36224/

Built to branch gh-pages at 2025-06-16 17:38 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.45%. Comparing base (c04e2f4) to head (d657301).
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36224      +/-   ##
===========================================
+ Coverage    64.43%   64.45%   +0.01%     
===========================================
  Files         3138     3138              
  Lines       104920   104920              
  Branches     19784    19789       +5     
===========================================
+ Hits         67608    67621      +13     
+ Misses       34625    34614      -11     
+ Partials      2687     2685       -2     
Flag Coverage Δ
e2e 57.65% <ø> (ø)
unit 69.04% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@julio-rocketchat julio-rocketchat added this to the 7.8.0 milestone Jun 16, 2025
@julio-rocketchat julio-rocketchat added the stat: QA assured Means it has been tested and approved by a company insider label Jun 16, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 16, 2025
@julio-rocketchat julio-rocketchat merged commit 2cdaabb into develop Jun 16, 2025
52 checks passed
@julio-rocketchat julio-rocketchat deleted the imported-fixes-2025-06-16 branch June 16, 2025 22:00
@julio-rocketchat
Copy link
Member Author

/patch

dionisio-bot bot pushed a commit that referenced this pull request Jun 19, 2025
Co-authored-by: FlyeraX <[email protected]>
Co-authored-by: jonasflorencio <[email protected]>
Co-authored-by: Kevin Aleman <[email protected]>
@dionisio-bot dionisio-bot bot mentioned this pull request Jun 19, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 19, 2025

Pull request #36250 added to Project: "Patch 7.7.2"

@julio-rocketchat
Copy link
Member Author

/backport 7.6.4

@julio-rocketchat
Copy link
Member Author

/backport 7.5.3

dionisio-bot bot pushed a commit that referenced this pull request Jun 19, 2025
Co-authored-by: FlyeraX <[email protected]>
Co-authored-by: jonasflorencio <[email protected]>
Co-authored-by: Kevin Aleman <[email protected]>
@dionisio-bot dionisio-bot bot mentioned this pull request Jun 19, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 19, 2025

Pull request #36251 added to Project: "Patch 7.6.4"

dionisio-bot bot pushed a commit that referenced this pull request Jun 19, 2025
Co-authored-by: FlyeraX <[email protected]>
Co-authored-by: jonasflorencio <[email protected]>
Co-authored-by: Kevin Aleman <[email protected]>
@dionisio-bot dionisio-bot bot mentioned this pull request Jun 19, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 19, 2025

Pull request #36252 added to Project: "Patch 7.5.3"

@julio-rocketchat
Copy link
Member Author

/backport 7.4.4

dionisio-bot bot pushed a commit that referenced this pull request Jun 19, 2025
Co-authored-by: FlyeraX <[email protected]>
Co-authored-by: jonasflorencio <[email protected]>
Co-authored-by: Kevin Aleman <[email protected]>
@julio-rocketchat
Copy link
Member Author

/backport 7.3.6

@dionisio-bot dionisio-bot bot mentioned this pull request Jun 19, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 19, 2025

Pull request #36253 added to Project: "Patch 7.4.4"

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 19, 2025

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-7.3.6-36224
git cherry-pick 2cdaabb50dd66c1dc735c14c16d9ef6acdc925f6
// solve the conflict
git push

after that just run /backport 7.3.6 again

julio-rocketchat added a commit that referenced this pull request Jun 19, 2025
Co-authored-by: FlyeraX <[email protected]>
Co-authored-by: jonasflorencio <[email protected]>
Co-authored-by: Kevin Aleman <[email protected]>
@julio-rocketchat
Copy link
Member Author

/backport 7.3.6

@dionisio-bot dionisio-bot bot mentioned this pull request Jun 19, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 19, 2025

Pull request #36254 added to Project: "Patch 7.3.6"

This was referenced Jun 20, 2025
@arthurblake
Copy link

Seems like the real issue details are always linked back to a private Atlassian site so no way to tell what the fix is about. Am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants