chore: remove useReactiveValue from useReplyInDMAction
#36217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
|
juliajforesti
changed the title
useReactiveVar from useReplyInDMActionuseReactiveValue from useReplyInDMAction
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36217 +/- ##
========================================
Coverage 64.53% 64.54%
========================================
Files 3148 3148
Lines 104625 104632 +7
Branches 19774 19777 +3
========================================
+ Hits 67522 67535 +13
+ Misses 34413 34408 -5
+ Partials 2690 2689 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
juliajforesti
force-pushed
the
chore/useReplyInDMAction
branch
from
e1bd4f6 to
cc28d59
Compare
tassoevan
approved these changes
Jun 18, 2025
tassoevan
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
nmagedman
added a commit
to seekingalpha/Rocket.Chat
that referenced
this pull request
Sep 17, 2025
…ocketChat#36217)" This reverts commit 1d6f335. Reverting experimentally to see if this commit changed the behavior of "Reply in direct message" (hiding it when there is no pre-existing room)
nmagedman
added a commit
to seekingalpha/Rocket.Chat
that referenced
this pull request
Sep 18, 2025
…e-d permission When PR RocketChat#36217 refactored useReplyInDMAction, it introduced a regression. We previously checked for `!canCreateDM` (with a bang!) but that PR accidentally negated it to `canCreateDM`. Additionally, the conditional that includes `canCreateDM` was duplicated. DRY it out.
nmagedman
added a commit
to nmagedman/Rocket.Chat
that referenced
this pull request
Sep 18, 2025
…e-d permission When PR RocketChat#36217 refactored useReplyInDMAction, it introduced a regression. We previously checked for `!canCreateDM` (with a bang!) but that PR accidentally negated it to `canCreateDM`. Additionally, the conditional that includes `canCreateDM` was duplicated. DRY it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARCH-1651
Proposed changes (including videos or screenshots)
Replace
useReactiveValuein favor of ZustandIssue(s)
Steps to test or reproduce
Further comments