Skip to content

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented Jun 11, 2025

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CTZ-210

Steps to test or reproduce

Further comments

This should help with some inconsistencies when evaluating this behavior as some places were using it and some others were not.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 11, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 11, 2025

🦋 Changeset detected

Latest commit: e619690

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.55%. Comparing base (dc694d9) to head (e619690).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36202      +/-   ##
===========================================
+ Coverage    64.53%   64.55%   +0.02%     
===========================================
  Files         3128     3128              
  Lines        98340    98340              
  Branches     18648    18653       +5     
===========================================
+ Hits         63461    63483      +22     
+ Misses       32055    32031      -24     
- Partials      2824     2826       +2     
Flag Coverage Δ
e2e 57.35% <ø> (+0.03%) ⬆️
unit 69.97% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KevLehman KevLehman added this to the 7.8.0 milestone Jun 11, 2025
@KevLehman KevLehman marked this pull request as ready for review June 11, 2025 18:35
@KevLehman KevLehman requested review from a team as code owners June 11, 2025 18:35
@KevLehman KevLehman changed the title chore: Use Livechat_enabled_when_agent_idle settting where it's accepted fix: Use Livechat_enabled_when_agent_idle settting where it's accepted Jun 11, 2025
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Jun 11, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 11, 2025
@kodiakhq kodiakhq bot merged commit 58fa34a into develop Jun 11, 2025
138 of 169 checks passed
@kodiakhq kodiakhq bot deleted the chore/missing-setting-usage branch June 11, 2025 23:01
@KevLehman
Copy link
Member Author

/patch

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 12, 2025

Pull request #36210 added to Project: "Patch 7.7.1"

This was referenced Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants