-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: Use Livechat_enabled_when_agent_idle settting where it's accepted
#36202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: e619690 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36202 +/- ##
===========================================
+ Coverage 64.53% 64.55% +0.02%
===========================================
Files 3128 3128
Lines 98340 98340
Branches 18648 18653 +5
===========================================
+ Hits 63461 63483 +22
+ Misses 32055 32031 -24
- Partials 2824 2826 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Livechat_enabled_when_agent_idle settting where it's acceptedLivechat_enabled_when_agent_idle settting where it's accepted
|
/patch |
|
Pull request #36210 added to Project: "Patch 7.7.1" |
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/CTZ-210
Steps to test or reproduce
Further comments
This should help with some inconsistencies when evaluating this behavior as some places were using it and some others were not.