Skip to content

Conversation

@d-gubert
Copy link
Member

@d-gubert d-gubert commented Jun 9, 2025

Proposed changes (including videos or screenshots)

Create a new endpoint that exports app logs as a file. Supports the same filters as the /api/apps/:id/logs endpoint.

Issue(s)

Steps to test or reproduce

Further comments

ALT-17

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 9, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.9.0, but it targets 7.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2025

🦋 Changeset detected

Latest commit: 6bbb7bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/rest-typings Minor
@rocket.chat/apps-engine Minor
@rocket.chat/meteor Minor
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/http-router Patch
@rocket.chat/models Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/apps Patch
@rocket.chat/core-typings Minor
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/network-broker Patch
@rocket.chat/livechat Patch
@rocket.chat/mock-providers Patch
@rocket.chat/cron Patch
@rocket.chat/instance-status Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Major
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@d-gubert d-gubert force-pushed the feat/apps-logs-export branch from 6f95f4a to abd2202 Compare June 9, 2025 18:55
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36186/

Built to branch gh-pages at 2025-07-12 21:17 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.35%. Comparing base (aaeb4f4) to head (6bbb7bd).
Report is 26 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36186      +/-   ##
===========================================
- Coverage    65.35%   65.35%   -0.01%     
===========================================
  Files         3156     3156              
  Lines       104142   104120      -22     
  Branches     19898    19890       -8     
===========================================
- Hits         68060    68043      -17     
+ Misses       33406    33396      -10     
- Partials      2676     2681       +5     
Flag Coverage Δ
e2e 58.38% <ø> (+<0.01%) ⬆️
unit 70.48% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@d-gubert d-gubert force-pushed the feat/apps-logs-export branch 7 times, most recently from 1b8dcff to af65f90 Compare June 11, 2025 23:53
@d-gubert d-gubert added this to the 7.8.0 milestone Jun 12, 2025
@d-gubert d-gubert force-pushed the feat/apps-logs-export branch from 7b2acf2 to 3c45d0c Compare June 12, 2025 13:24
@d-gubert d-gubert marked this pull request as ready for review June 12, 2025 16:43
@d-gubert d-gubert requested review from a team as code owners June 12, 2025 16:43
@d-gubert
Copy link
Member Author

Closing this one as we merged the branch into #36403

@d-gubert d-gubert closed this Jul 17, 2025
@d-gubert d-gubert deleted the feat/apps-logs-export branch July 17, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants