Skip to content

Conversation

@d-gubert
Copy link
Member

@d-gubert d-gubert commented Jun 5, 2025

Proposed changes (including videos or screenshots)

The action button manager was still sending the action buttons even if the app that registered them was not enabled.

Issue(s)

Steps to test or reproduce

Further comments

CONN-688

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 5, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2025

🦋 Changeset detected

Latest commit: 067564d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 38 packages
Name Type
@rocket.chat/apps-engine Minor
@rocket.chat/meteor Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/core-typings Minor
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/rest-typings Minor
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/gazzodown Major
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@d-gubert d-gubert added this to the 7.8.0 milestone Jun 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36169/

Built to branch gh-pages at 2025-06-19 02:22 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.41%. Comparing base (1bf63f0) to head (067564d).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36169      +/-   ##
===========================================
- Coverage    64.41%   64.41%   -0.01%     
===========================================
  Files         3147     3147              
  Lines       105216   105218       +2     
  Branches     19898    19897       -1     
===========================================
+ Hits         67771    67772       +1     
- Misses       34751    34752       +1     
  Partials      2694     2694              
Flag Coverage Δ
e2e 57.62% <ø> (-0.02%) ⬇️
unit 68.88% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@d-gubert d-gubert force-pushed the fix/app-action-buttons-disabled branch 3 times, most recently from 671213e to 43f1508 Compare June 8, 2025 20:00
@d-gubert d-gubert force-pushed the fix/app-action-buttons-disabled branch from 43f1508 to 94b1db2 Compare June 16, 2025 12:15
@d-gubert d-gubert force-pushed the fix/app-action-buttons-disabled branch from 94b1db2 to 6771ee0 Compare June 18, 2025 20:27
@d-gubert d-gubert marked this pull request as ready for review June 18, 2025 21:32
@d-gubert d-gubert requested a review from a team as a code owner June 18, 2025 21:32
@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label Jun 19, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 19, 2025
@kodiakhq kodiakhq bot merged commit 5ac20e2 into develop Jun 19, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/app-action-buttons-disabled branch June 19, 2025 03:11
This was referenced Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants