-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: incoming webhook message not respecting Message_MaxAllowedSize setting #36163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…etting Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
|
Looks like this PR is ready to merge! 🎉 |
|
A potentially more appropriate place for this validation could be within the Note: This refers to the |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36163 +/- ##
===========================================
+ Coverage 64.43% 64.45% +0.02%
===========================================
Files 3138 3138
Lines 104920 104920
Branches 19784 19784
===========================================
+ Hits 67601 67628 +27
+ Misses 34631 34610 -21
+ Partials 2688 2682 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
🦋 Changeset detectedLatest commit: d9789a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Proposed changes (including videos or screenshots)
This PR fixes an issue where incoming webhook messages could exceed the allowed characters per message setting.
Issue(s)
Steps to test or reproduce
Further comments
Closes SUP-796