Skip to content

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jun 5, 2025

Proposed changes (including videos or screenshots)

It completely replaces the Minimongo collection for Messages with the Zustand store.

Issue(s)

ARCH-1641

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2025

⚠️ No Changeset found

Latest commit: dbf8caf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 5, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36158/

Built to branch gh-pages at 2025-06-06 03:12 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 52.00000% with 120 lines in your changes missing coverage. Please review.

Project coverage is 63.32%. Comparing base (d6fa67e) to head (df13745).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36158      +/-   ##
===========================================
- Coverage    64.61%   63.32%   -1.29%     
===========================================
  Files         3128     2938     -190     
  Lines        98189    95391    -2798     
  Branches     18636    17969     -667     
===========================================
- Hits         63442    60405    -3037     
- Misses       31919    32397     +478     
+ Partials      2828     2589     -239     
Flag Coverage Δ
e2e 53.86% <49.26%> (-3.72%) ⬇️
unit 69.93% <45.26%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tassoevan tassoevan force-pushed the chore/messages-store branch from aa27b39 to c8dc829 Compare June 6, 2025 03:09
@tassoevan tassoevan force-pushed the chore/messages-store branch from df13745 to dbf8caf Compare June 6, 2025 14:33
@tassoevan tassoevan marked this pull request as ready for review June 6, 2025 17:51
@tassoevan tassoevan requested a review from a team as a code owner June 6, 2025 17:51
@ggazzo ggazzo added this to the 7.8.0 milestone Jun 7, 2025
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jun 7, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 7, 2025
@ggazzo ggazzo merged commit c992c79 into develop Jun 7, 2025
96 checks passed
@ggazzo ggazzo deleted the chore/messages-store branch June 7, 2025 14:42
@abhinavkrin abhinavkrin restored the chore/messages-store branch June 26, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants