-
Notifications
You must be signed in to change notification settings - Fork 13k
feat: New Collapse component for Apps logs #36142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 72ee6be The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
0ecc31b to
9a3600e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #36142 +/- ##
===========================================
+ Coverage 64.54% 64.80% +0.26%
===========================================
Files 3148 3153 +5
Lines 104632 104788 +156
Branches 19775 19963 +188
===========================================
+ Hits 67530 67913 +383
+ Misses 34416 34186 -230
- Partials 2686 2689 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppLogs/AppLogs.tsx
Outdated
Show resolved
Hide resolved
d-gubert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from apps perspective
Proposed changes (including videos or screenshots)
Rewrites the existing log items to use a new component, using Accordions in this page could lead to accessibility issues due the Accordion "Title" not being a title per se. Also some visuals where updated to a new design
Issue(s)
ALT-8