Skip to content

Conversation

@MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented Jun 3, 2025

Proposed changes (including videos or screenshots)

Rewrites the existing log items to use a new component, using Accordions in this page could lead to accessibility issues due the Accordion "Title" not being a title per se. Also some visuals where updated to a new design

image

Issue(s)

ALT-8

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 3, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 3, 2025

🦋 Changeset detected

Latest commit: 72ee6be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 38 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/i18n Minor
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/ui-voip Major
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/http-router Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36142/

Built to branch gh-pages at 2025-06-21 02:21 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@MartinSchoeler MartinSchoeler force-pushed the feat/app-logs-item-redesign branch from 0ecc31b to 9a3600e Compare June 4, 2025 18:37
@codecov
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

Attention: Patch coverage is 98.48485% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.80%. Comparing base (93acfbe) to head (72ee6be).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36142      +/-   ##
===========================================
+ Coverage    64.54%   64.80%   +0.26%     
===========================================
  Files         3148     3153       +5     
  Lines       104632   104788     +156     
  Branches     19775    19963     +188     
===========================================
+ Hits         67530    67913     +383     
+ Misses       34416    34186     -230     
- Partials      2686     2689       +3     
Flag Coverage Δ
e2e 57.56% <23.07%> (-0.02%) ⬇️
unit 69.60% <98.48%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review June 4, 2025 19:49
@MartinSchoeler MartinSchoeler requested review from a team as code owners June 4, 2025 19:49
d-gubert
d-gubert previously approved these changes Jun 11, 2025
Copy link
Member

@d-gubert d-gubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from apps perspective

@MartinSchoeler MartinSchoeler requested a review from d-gubert June 17, 2025 12:54
@tassoevan tassoevan dismissed d-gubert’s stale review June 17, 2025 15:13

issues addressed

@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Jun 17, 2025
@d-gubert d-gubert added this to the 7.8.0 milestone Jun 17, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 17, 2025
@d-gubert d-gubert removed this from the 7.8.0 milestone Jun 17, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 17, 2025
@MartinSchoeler MartinSchoeler added this to the 7.8.0 milestone Jun 20, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 20, 2025
@kodiakhq kodiakhq bot merged commit 0ba4d8b into develop Jun 21, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the feat/app-logs-item-redesign branch June 21, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants