-
Notifications
You must be signed in to change notification settings - Fork 13k
fix: Broken contextual-bar app view on refresh #36138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: a2edd79 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36138 +/- ##
========================================
Coverage 64.54% 64.54%
========================================
Files 3128 3128
Lines 98304 98334 +30
Branches 18653 18682 +29
========================================
+ Hits 63449 63469 +20
- Misses 32031 32040 +9
- Partials 2824 2825 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…t/Rocket.Chat into fix/url-contextual-bar-surface
Proposed changes (including videos or screenshots)
This pull request clarifies that making an intent request via
apps/ui.interactionor rely on app interaction call by URL is not feasible because UiKit interactions must be initiated by the user interaction in the UI. Instead, acloseTab()function is employed to restore the chat to a clean state, effectively closing the current interaction and resetting the interface for a new intent on refresh the page.Issue(s)
closes #35841
Steps to test or reproduce
Further comments
SUP-806