Skip to content

Conversation

@tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Jun 3, 2025

Proposed changes (including videos or screenshots)

This pull request clarifies that making an intent request via apps/ui.interaction or rely on app interaction call by URL is not feasible because UiKit interactions must be initiated by the user interaction in the UI. Instead, a closeTab() function is employed to restore the chat to a clean state, effectively closing the current interaction and resetting the interface for a new intent on refresh the page.

Issue(s)

closes #35841

Steps to test or reproduce

Further comments

SUP-806

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 3, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 3, 2025

🦋 Changeset detected

Latest commit: a2edd79

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36138/

Built to branch gh-pages at 2025-06-09 18:54 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.54%. Comparing base (fda0eaf) to head (a2edd79).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #36138   +/-   ##
========================================
  Coverage    64.54%   64.54%           
========================================
  Files         3128     3128           
  Lines        98304    98334   +30     
  Branches     18653    18682   +29     
========================================
+ Hits         63449    63469   +20     
- Misses       32031    32040    +9     
- Partials      2824     2825    +1     
Flag Coverage Δ
e2e 57.32% <75.00%> (-0.04%) ⬇️
unit 69.98% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tiagoevanp tiagoevanp marked this pull request as ready for review June 6, 2025 19:03
@tiagoevanp tiagoevanp requested a review from a team as a code owner June 6, 2025 19:03
@tassoevan tassoevan added this to the 7.8.0 milestone Jun 9, 2025
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Jun 9, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 9, 2025
@kodiakhq kodiakhq bot merged commit 78f9f3d into develop Jun 9, 2025
71 of 73 checks passed
@kodiakhq kodiakhq bot deleted the fix/url-contextual-bar-surface branch June 9, 2025 20:37
This was referenced Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Contextual Bar Fails to Open or Update After UI Reload (Cmd+R)

3 participants