refactor: remove computation from LegacyRoomManager #36135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Contributor
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #36135 +/- ##
===========================================
- Coverage 64.79% 64.79% -0.01%
===========================================
Files 3153 3153
Lines 104876 104859 -17
Branches 19985 20019 +34
===========================================
- Hits 67955 67943 -12
+ Misses 34242 34228 -14
- Partials 2679 2688 +9
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ggazzo
force-pushed
the
chore/room-manager
branch
4 times, most recently
from
63981a0 to
7a83ab2
Compare
ggazzo
force-pushed
the
chore/room-manager
branch
from
e36af0a to
67fee8c
Compare
ggazzo
force-pushed
the
chore/room-manager
branch
from
67fee8c to
0b1f93f
Compare
…placing UnreadSince class with direct Date handling and introducing new listener functions
ggazzo
force-pushed
the
chore/room-manager
branch
from
7965260 to
9d2c4d7
Compare
…ctive in LegacyRoomManager
…ening logic in LegacyRoomManager
tassoevan
reviewed
Jun 27, 2025
Co-authored-by: Tasso Evangelista <[email protected]>
tassoevan
approved these changes
Jul 1, 2025
tassoevan
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
ggazzo
added a commit
that referenced
this pull request
Jul 2, 2025
Co-authored-by: Tasso Evangelista <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
sem22-dev
pushed a commit
to sem22-dev/Rocket.Chat
that referenced
this pull request
Jul 4, 2025
Co-authored-by: Tasso Evangelista <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
MartinSchoeler
pushed a commit
that referenced
this pull request
Jul 10, 2025
Co-authored-by: Tasso Evangelista <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rocketchat.atlassian.net/browse/ARCH-1684
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments