Skip to content

Conversation

@aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Jun 2, 2025

Proposed changes (including videos or screenshots)

This PR adds:

  • hideExpandChat option to the Livechat widget API's setTheme method to allow disabling the 'Expand chat' feature when needed.
  • New setting "Hide 'Expand chat'" to Livechat Appearance page
Screen.Recording.2025-06-03.at.10.17.29.mov

Screenshot 2025-06-03 at 14 41 33

Issue(s)

CTZ-156
CTZ-205

Steps to test or reproduce

  • With the livechat widget embeded
  • Use:
window.RocketChat.livechat.setTheme({ hideExpandChat: true });
// OR
window.RocketChat(function() {
  this.setTheme({ hideExpandChat: true });
});
  • Expand chat should be visible (or not) depending on the value set

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 2, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 2, 2025

🦋 Changeset detected

Latest commit: 24cd3c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/livechat Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36127/

Built to branch gh-pages at 2025-06-17 12:49 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.42%. Comparing base (2cdaabb) to head (1f90bc2).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36127      +/-   ##
===========================================
- Coverage    64.42%   64.42%   -0.01%     
===========================================
  Files         3138     3138              
  Lines       104932   104930       -2     
  Branches     19780    19780              
===========================================
- Hits         67604    67600       -4     
- Misses       34643    34645       +2     
  Partials      2685     2685              
Flag Coverage Δ
unit 68.99% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aleksandernsilva aleksandernsilva force-pushed the feat/livechat-hide-popout-mode branch 4 times, most recently from 25927d3 to a81746c Compare June 3, 2025 12:55
@aleksandernsilva aleksandernsilva changed the title feat: Allow hiding 'Expand chat' button via Livechat API feat: Allow hiding 'Expand chat' button via Livechat widget API Jun 3, 2025
@aleksandernsilva aleksandernsilva force-pushed the feat/livechat-hide-popout-mode branch 3 times, most recently from 747190b to 5ebec16 Compare June 3, 2025 22:17
@aleksandernsilva aleksandernsilva marked this pull request as ready for review June 4, 2025 13:21
@aleksandernsilva aleksandernsilva requested review from a team as code owners June 4, 2025 13:21
@aleksandernsilva aleksandernsilva added this to the 7.8.0 milestone Jun 4, 2025
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Jun 16, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 16, 2025
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 16, 2025
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jun 16, 2025

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@aleksandernsilva aleksandernsilva force-pushed the feat/livechat-hide-popout-mode branch from 5ebec16 to 24cd3c9 Compare June 17, 2025 12:38
@aleksandernsilva aleksandernsilva force-pushed the feat/livechat-hide-popout-mode branch from 1f90bc2 to 24cd3c9 Compare June 17, 2025 13:10
@aleksandernsilva aleksandernsilva added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Jun 17, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 17, 2025
@kodiakhq kodiakhq bot merged commit 52e093e into develop Jun 17, 2025
165 of 185 checks passed
@kodiakhq kodiakhq bot deleted the feat/livechat-hide-popout-mode branch June 17, 2025 15:26
This was referenced Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants