fix: improve error handling no ddp-streamer #36105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 0834cea The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36105 +/- ##
===========================================
+ Coverage 64.77% 64.78% +0.01%
===========================================
Files 3153 3153
Lines 104861 104861
Branches 19976 19976
===========================================
+ Hits 67920 67932 +12
+ Misses 34254 34243 -11
+ Partials 2687 2686 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
|
ggazzo
previously requested changes
May 29, 2025
Member
ggazzo
left a comment
ggazzo
left a comment
There was a problem hiding this comment.
what about adding a global handler as we do for the main process?
ggazzo
force-pushed
the
improve-error-handling-ddp-streamer
branch
from
122e857 to
0834cea
Compare
MarcosSpessatto
approved these changes
Jun 27, 2025
ggazzo
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
ggazzo
added a commit
that referenced
this pull request
Jun 27, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Member
|
/patch |
dionisio-bot bot
pushed a commit
that referenced
this pull request
Jun 27, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Contributor
|
Pull request #36323 added to Project: "Patch 7.7.2" |
Merged
cardoso
reviewed
Jun 27, 2025
| } | ||
| }); | ||
|
|
||
| process.on('uncaughtException', async (error) => { |
sem22-dev
pushed a commit
to sem22-dev/Rocket.Chat
that referenced
this pull request
Jul 4, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Merged
MartinSchoeler
pushed a commit
that referenced
this pull request
Jul 10, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rocketchat.atlassian.net/browse/ARCH-1693
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments