Skip to content

Conversation

@aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented May 28, 2025

Proposed changes (including videos or screenshots)

Most columns in the Contact Center table don't have indexes that support efficient sorting. Sorting on these columns can slow down the system and put extra load on the database. Taking up to 1min initial load for some workspaces.

To improve performance and avoid unnecessary database work, sorting is now only allowed on the "Name" and "Started at" columns, which do have proper indexes.

Issue(s)

CTZ-102

Steps to test or reproduce

  • Open workspace
  • If needed Workspace > Settings > Omnichannel > Enabled
  • Access Contact Center
  • Chats table show only allow to sort "Name" and "Started at"

Further comments

If we identify a need for sorting on other columns in the future, we’ll plan and implement it properly with the necessary database support.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 28, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented May 28, 2025

🦋 Changeset detected

Latest commit: edec0f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aleksandernsilva aleksandernsilva changed the title fix: Disabled sorting for columns without an index in Omnichannel Contact Center fix: Disabled sorting for non-indexed columns in Omnichannel Contact Center May 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36100/

Built to branch gh-pages at 2025-06-16 16:11 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.43%. Comparing base (a91645c) to head (edec0f8).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #36100   +/-   ##
========================================
  Coverage    64.43%   64.43%           
========================================
  Files         3138     3139    +1     
  Lines       104920   104927    +7     
  Branches     19783    19806   +23     
========================================
+ Hits         67600    67607    +7     
- Misses       34632    34635    +3     
+ Partials      2688     2685    -3     
Flag Coverage Δ
e2e 57.66% <100.00%> (+0.02%) ⬆️
unit 69.01% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aleksandernsilva aleksandernsilva force-pushed the fix/remove-omni-cc-sorting branch from 8b256bd to bf5f677 Compare May 28, 2025 13:38
@aleksandernsilva aleksandernsilva force-pushed the fix/remove-omni-cc-sorting branch from bf5f677 to 667d56b Compare May 28, 2025 14:12
@aleksandernsilva aleksandernsilva marked this pull request as ready for review June 2, 2025 18:44
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner June 2, 2025 18:44
@aleksandernsilva aleksandernsilva added this to the 7.8.0 milestone Jun 2, 2025
@juliajforesti juliajforesti added the stat: QA assured Means it has been tested and approved by a company insider label Jun 16, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 16, 2025
@kodiakhq kodiakhq bot merged commit df4a0d1 into develop Jun 16, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/remove-omni-cc-sorting branch June 16, 2025 16:59
This was referenced Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants