-
Notifications
You must be signed in to change notification settings - Fork 13k
feat: Replace cancel by reset in notifications and export messages tab #36091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 843a8b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36091 +/- ##
===========================================
+ Coverage 64.96% 64.99% +0.03%
===========================================
Files 3112 3113 +1
Lines 93709 93802 +93
Branches 17769 17817 +48
===========================================
+ Hits 60875 60967 +92
+ Misses 30057 30052 -5
- Partials 2777 2783 +6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
8b6a74a to
07e118e
Compare
Proposed changes (including videos or screenshots)
In order to give more options to the users and add consistency when working with forms we're replacing the cancel button, which is pretty much the same action we have when closing the contextual bar, and adding a option to reset the form in
NotificationPreferencesandExportMessagesIssue(s)
Steps to test or reproduce
Further comments
CORE-1115