Skip to content

Conversation

@yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented May 27, 2025

Proposed changes (including videos or screenshots)

In order to give more options to the users and add consistency when working with forms we're replacing the cancel button, which is pretty much the same action we have when closing the contextual bar, and adding a option to reset the form in NotificationPreferences and ExportMessages

Issue(s)

Steps to test or reproduce

Further comments

CORE-1115

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 27, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented May 27, 2025

🦋 Changeset detected

Latest commit: 843a8b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yash-rajpal yash-rajpal changed the title WIP: button groups contextual bar fix: Contextual bar button group behavior May 27, 2025
@yash-rajpal yash-rajpal changed the title fix: Contextual bar button group behavior fix: Contextualbars button group behavior May 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 27, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36091/

Built to branch gh-pages at 2025-06-03 21:04 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.99%. Comparing base (880cb02) to head (843a8b8).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36091      +/-   ##
===========================================
+ Coverage    64.96%   64.99%   +0.03%     
===========================================
  Files         3112     3113       +1     
  Lines        93709    93802      +93     
  Branches     17769    17817      +48     
===========================================
+ Hits         60875    60967      +92     
+ Misses       30057    30052       -5     
- Partials      2777     2783       +6     
Flag Coverage Δ
e2e 58.44% <100.00%> (+0.05%) ⬆️
unit 71.71% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yash-rajpal yash-rajpal marked this pull request as ready for review June 2, 2025 15:49
@yash-rajpal yash-rajpal requested a review from a team as a code owner June 2, 2025 15:49
@dougfabris dougfabris changed the base branch from feat/contextual-bar-accessibility to develop June 3, 2025 16:49
@dougfabris dougfabris added this to the 7.8.0 milestone Jun 3, 2025
@dougfabris dougfabris changed the title fix: Contextualbars button group behavior feat: Reset option instead of cancel in notifications and export messages tab Jun 3, 2025
@dougfabris dougfabris changed the title feat: Reset option instead of cancel in notifications and export messages tab feat: Replace cancel with reset action in notifications and export messages tab Jun 3, 2025
@dougfabris dougfabris changed the title feat: Replace cancel with reset action in notifications and export messages tab feat: Replace cancel by reset in notifications and export messages tab Jun 3, 2025
@dougfabris dougfabris force-pushed the button-group-contextualbar branch from 8b6a74a to 07e118e Compare June 3, 2025 18:36
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Jun 3, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 3, 2025
@kodiakhq kodiakhq bot merged commit c008401 into develop Jun 3, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the button-group-contextualbar branch June 3, 2025 23:55
This was referenced Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants