-
Notifications
You must be signed in to change notification settings - Fork 13.1k
regression: Dragging the VoIP popup handle with right click keeps moving the element after release #36086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.7.0 #36086 +/- ##
=================================================
+ Coverage 64.21% 64.76% +0.54%
=================================================
Files 3018 3110 +92
Lines 91840 93199 +1359
Branches 17437 17749 +312
=================================================
+ Hits 58979 60358 +1379
+ Misses 30173 30051 -122
- Partials 2688 2790 +102
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
There was no limit to which buttons were allowed to drag the element, and right clicking a page opens the context menu. This makes the mechanism unable to identify that the click was released, so the element would still move around with the mouse even if no button is pressed.
Since we expect the right click to always open the context menu, the popup should now ignore right clicks.
Issue(s)
CORE-1170
Steps to test or reproduce
Right click the popup then close the context menu. The popup will follow the cursor despite no buttons being held.
Further comments