Skip to content

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented May 26, 2025

Proposed changes (including videos or screenshots)

There was no limit to which buttons were allowed to drag the element, and right clicking a page opens the context menu. This makes the mechanism unable to identify that the click was released, so the element would still move around with the mouse even if no button is pressed.

Since we expect the right click to always open the context menu, the popup should now ignore right clicks.

Issue(s)

CORE-1170

Steps to test or reproduce

Right click the popup then close the context menu. The popup will follow the cursor despite no buttons being held.

Further comments

@gabriellsh gabriellsh added this to the 7.7.0 milestone May 26, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 26, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented May 26, 2025

⚠️ No Changeset found

Latest commit: 15088aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36086/

Built to branch gh-pages at 2025-05-26 22:57 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented May 26, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.76%. Comparing base (e7b88b6) to head (15088aa).
Report is 3 commits behind head on release-7.7.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.7.0   #36086      +/-   ##
=================================================
+ Coverage          64.21%   64.76%   +0.54%     
=================================================
  Files               3018     3110      +92     
  Lines              91840    93199    +1359     
  Branches           17437    17749     +312     
=================================================
+ Hits               58979    60358    +1379     
+ Misses             30173    30051     -122     
- Partials            2688     2790     +102     
Flag Coverage Δ
e2e 58.42% <ø> (+1.74%) ⬆️
unit 71.54% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ggazzo
ggazzo previously approved these changes May 27, 2025
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label May 27, 2025
@ggazzo ggazzo merged commit c7c95d8 into release-7.7.0 May 27, 2025
42 checks passed
@ggazzo ggazzo deleted the reg/draggableRightClick branch May 27, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants