Skip to content

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented May 26, 2025

Proposed changes (including videos or screenshots)

Depending on system specs and usage, dragging the popup too quickly or to the edges of the screen triggers text selection. This can also cause the underlying elements to scroll due to the browser scrolling the content to match the selection position.

This was fixed by simply adding event.preventDefault when an user starts dragging the popup.

Also increased the automated tests to ensure this behaviour. Despite the simple fix, automating tests was not as trivial, but luckly it was possible to do.

Issue(s)

CORE-1169

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented May 26, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented May 26, 2025

⚠️ No Changeset found

Latest commit: e30b579

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gabriellsh gabriellsh added this to the 7.7.0 milestone May 26, 2025
@github-actions
Copy link
Contributor

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36084/

Built to branch gh-pages at 2025-05-26 21:59 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented May 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.60%. Comparing base (93eb903) to head (e30b579).
Report is 1 commits behind head on release-7.7.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.7.0   #36084      +/-   ##
=================================================
- Coverage          64.20%   63.60%   -0.60%     
=================================================
  Files               3018     2922      -96     
  Lines              91839    90815    -1024     
  Branches           17433    17118     -315     
=================================================
- Hits               58967    57767    -1200     
- Misses             30185    30505     +320     
+ Partials            2687     2543     -144     
Flag Coverage Δ
e2e 54.63% <ø> (-2.04%) ⬇️
unit 71.63% <0.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gabriellsh gabriellsh changed the base branch from develop to release-7.7.0 May 26, 2025 22:45
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label May 27, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 27, 2025
@kodiakhq kodiakhq bot merged commit e7b88b6 into release-7.7.0 May 27, 2025
50 of 54 checks passed
@kodiakhq kodiakhq bot deleted the reg/draggableTextSelection branch May 27, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants